Skip to content

Conversation

@vpashovski
Copy link
Contributor

@vpashovski vpashovski commented Nov 20, 2025

Fix: Deprecated Functionality: Implicitly marking parameter as nullable is deprecated, the explicit nullable type must be used;

Summary by CodeRabbit

  • Refactor
    • Updated internal type declarations for improved code consistency and type safety across the codebase.

✏️ Tip: You can customize this high-level summary in your review settings.

…le is deprecated, the explicit nullable type must be used;
@coderabbitai
Copy link

coderabbitai bot commented Nov 20, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This pull request updates constructor and method signatures across multiple classes to use explicit nullable type declarations. The changes involve converting implicit nullable parameters (using = null defaults) to explicit nullable types using the ? syntax in PHP. Affected files include adminhtml blocks, console commands, configuration backend models, product models, and view models. Type declarations are updated for parameters such as Quote, $name, resource dependencies, serializers, and store IDs. The functional behavior remains unchanged, as default null values are preserved.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot previously approved these changes Nov 20, 2025
added 2 additional checks for null parameters
@jm-extend jm-extend merged commit c6529db into helloextend:master Nov 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants