Skip to content

PHP 8.4 Compatibility - Fix Deprecated Functionality #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jm-extend merged 2 commits into from
Nov 21, 2025
Merged

PHP 8.4 Compatibility - Fix Deprecated Functionality #427

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ec9780
Fix: Deprecated Functionality: Implicitly marking parameter as nullab…
vpashovski Nov 20, 2025
07c94fe
Update Warranty.php
jm-extend Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Block/Adminhtml/Order/Create/Installation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class Installation extends Template

public function __construct(
\Magento\Backend\Block\Template\Context $context,
\Magento\Backend\Model\Session\Quote $quote = null,
?\Magento\Backend\Model\Session\Quote $quote = null,
array $data = []
){
$this->quote = $quote ?? \Magento\Framework\App\ObjectManager::getInstance()
Expand Down
2 changes: 1 addition & 1 deletion Console/Command/CreateContracts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public function __construct(
DataHelper $dataHelper,
ContractCreateProcess $contractCreateProcess,
LoggerInterface $logger,
string $name = null
?string $name = null
) {
$this->appState = $appState;
$this->dataHelper = $dataHelper;
Expand Down
2 changes: 1 addition & 1 deletion Console/Command/CreateWarrantyProduct.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public function __construct(
LoggerInterface $logger,
ResourceProductFactory $resourceProductFactory,
StoreManagerInterface $storeManager,
string $name = null
?string $name = null
) {
parent::__construct($name);
$this->productRepository = $productRepository;
Expand Down
2 changes: 1 addition & 1 deletion Console/Command/ResetProductSyncFlag.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public function __construct(
AppState $appState,
FlagManager $flagManager,
LoggerInterface $logger,
string $name = null
?string $name = null
) {
$this->appState = $appState;
$this->flagManager = $flagManager;
Expand Down
2 changes: 1 addition & 1 deletion Console/Command/SendOrders.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public function __construct(
HistoricalOrdersSyncProcess $sendHistoricalOrders,
GetAfterDate $getAfterDate,
LoggerInterface $logger,
string $name = null
?string $name = null
) {
parent::__construct($name);
$this->appState = $appState;
Expand Down
2 changes: 1 addition & 1 deletion Console/Command/SyncProducts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public function __construct(
FlagManager $flagManager,
ProductSyncProcess $productSyncProcess,
LoggerInterface $logger,
string $name = null
?string $name = null
) {
parent::__construct($name);
$this->appState = $appState;
Expand Down
4 changes: 2 additions & 2 deletions Model/Config/Backend/ContractCreationCronSchedule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ public function __construct(
ScopeConfigInterface $config,
TypeListInterface $cacheTypeList,
Helper $helper,
AbstractResource $resource = null,
AbstractDb $resourceCollection = null,
?AbstractResource $resource = null,
?AbstractDb $resourceCollection = null,
array $data = []
) {
$this->helper = $helper;
Expand Down
4 changes: 2 additions & 2 deletions Model/Config/Backend/OrdersSyncCronSchedule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ public function __construct(
ScopeConfigInterface $config,
TypeListInterface $cacheTypeList,
Helper $helper,
AbstractResource $resource = null,
AbstractDb $resourceCollection = null,
?AbstractResource $resource = null,
?AbstractDb $resourceCollection = null,
array $data = []
) {
$this->helper = $helper;
Expand Down
4 changes: 2 additions & 2 deletions Model/Config/Backend/ProductSyncCronSchedule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ public function __construct(
ScopeConfigInterface $config,
TypeListInterface $cacheTypeList,
Helper $helper,
AbstractResource $resource = null,
AbstractDb $resourceCollection = null,
?AbstractResource $resource = null,
?AbstractDb $resourceCollection = null,
array $data = []
) {
$this->helper = $helper;
Expand Down
2 changes: 1 addition & 1 deletion Model/Product/Type.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public function __construct(
\Psr\Log\LoggerInterface $logger,
ProductRepositoryInterface $productRepository,
Data $helper,
\Magento\Framework\Serialize\Serializer\Json $serializer = null
?\Magento\Framework\Serialize\Serializer\Json $serializer = null
)
{
$this->helper = $helper;
Expand Down
2 changes: 1 addition & 1 deletion Model/ProductSyncProcess.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ public function __construct(
* @param int|null $defaultBatchSize
* @return void
*/
public function execute(int $defaultBatchSize = null)
public function execute(?int $defaultBatchSize = null)
{
$stores = $this->storeManager->getStores();
foreach ($stores as $storeId => $store) {
Expand Down
2 changes: 1 addition & 1 deletion ViewModel/Warranty.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ public function __construct(
*
* @return bool
*/
public function isExtendEnabled(int $storeId = null): bool
public function isExtendEnabled(?int $storeId = null): bool
{
$result = false;

Expand Down