fix(ios): add <string> and <memory> includes in RNDatePicker.mm #941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add guarded C++ includes (
<string>
,<memory>
) required bystd::string
and smart pointers used inRNDatePicker.mm
.Why
On newer React Native versions (tested on RN 0.81.1 with Xcode 15 / Apple Silicon), the iOS build fails with:
No type named 'string' in namespace 'std' because the file uses C++ types without including the proper headers.
This issue was not visible on older RN versions (e.g. 0.73.x) but breaks compilation starting with RN 0.81.x due to stricter C++ toolchains.
How
Minimal change: add the missing includes at the top of
RNDatePicker.mm
, guarded by#ifdef __cplusplus
to ensure safety even if the file is compiled as Objective-C.Testing
Breaking changes
None