Skip to content

fix(ios): add <string> and <memory> includes in RNDatePicker.mm #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(ios): add <string> and <memory> includes in RNDatePicker.mm #941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a23a26
fix(ios): include <string> and <memory> in RNDatePicker.mm to fix std…
Sep 4, 2025
98d915e
chore(lint): format DatePickerIOS.js to satisfy prettier
Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ios/RNDatePicker.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
#import <react/renderer/components/RNDatePickerSpecs/RCTComponentViewHelpers.h>
#import "RCTFabricComponentsPlugins.h"

#ifdef __cplusplus
#include <string>
#include <memory>
#endif

using namespace facebook::react;

#else
Expand Down
8 changes: 6 additions & 2 deletions src/DatePickerIOS.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,12 @@
style: [styles.datePickerIOS, props.style],
date: props.date ? props.date.toISOString() : undefined,
locale: props.locale ? props.locale : undefined,
maximumDate: props.maximumDate ? props.maximumDate.toISOString() : undefined,
minimumDate: props.minimumDate ? props.minimumDate.toISOString() : undefined,
maximumDate: props.maximumDate

Check failure on line 26 in src/DatePickerIOS.js

View workflow job for this annotation

GitHub Actions / Check / Lint 

Replace `·?·props.maximumDate.toISOString()` with `⏎······?·props.maximumDate.toISOString()⏎·····`
? props.maximumDate.toISOString()

Check failure on line 27 in src/DatePickerIOS.js

View workflow job for this annotation

GitHub Actions / Check / Lint 

Replace `·?·props.minimumDate.toISOString()` with `⏎······?·props.minimumDate.toISOString()⏎·····`
: undefined,
minimumDate: props.minimumDate
? props.minimumDate.toISOString()
: undefined,
theme: props.theme ? props.theme : 'auto',
}

Expand Down
Loading