fix(docker): bump cargo-zigbuild to 0.23.0 so the arm64 leg links again - #245
Merged
Conversation
The 1.98 toolchain bump (#241) is green on every CI check and still breaks the image: `docker.yml` fires on tags and pushes to `main`, not on pull requests, so the first build to run it was v0.30.1's — and only the arm64 leg failed. Rust 1.98 passes `--fix-cortex-a53-843419` to the linker for aarch64 targets (rust-lang/rust#155453). Zig's linker rejects unknown arguments outright, so the wrapper cargo-zigbuild 0.22.3 generates fails with `unsupported linker arg: --fix-cortex-a53-843419` and `noadd` never links for aarch64-unknown-linux-musl. amd64 is unaffected — the argument is only emitted for aarch64. cargo-zigbuild 0.23.0 filters the argument in `filter_linker_arg` (rust-cross/cargo-zigbuild#452), alongside the two other arguments it already dropped for the same reason. The rest of the 0.22.3..0.23.0 range is a cargo-dist config update, a cargo-options bump, and dependabot commits. Zig stays on 0.14.1: the fix is in the wrapper, not the linker, and 0.15+ still brings the libc++-19 bindgen requirement this pin exists to avoid. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RLF7TP74kER7Wcx8Th33qc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
=======================================
Coverage 90.82% 90.82%
=======================================
Files 29 29
Lines 10647 10647
=======================================
Hits 9670 9670
Misses 977 977 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1.98 toolchain bump (#241) is green on every CI check and still breaks the
image:
docker.ymlfires on tags and pushes tomain, not on pull requests, sothe first build to run it was v0.30.1's — and only the arm64 leg failed
(run).
Rust 1.98 passes
--fix-cortex-a53-843419to the linker for aarch64 targets(rust-lang/rust#155453). Zig's linker rejects unknown arguments outright, so the
wrapper cargo-zigbuild 0.22.3 generates fails with
unsupported linker arg: --fix-cortex-a53-843419andnoaddnever links foraarch64-unknown-linux-musl. amd64 is unaffected — the argument is only emittedfor aarch64.
cargo-zigbuild 0.23.0 filters the argument in
filter_linker_arg(rust-cross/cargo-zigbuild#452), alongside the two other arguments it already
dropped for the same reason. The rest of the 0.22.3..0.23.0 range is a
cargo-dist config update, a cargo-options bump, and dependabot commits.
Zig stays on 0.14.1: the fix is in the wrapper, not the linker, and 0.15+ still
brings the libc++-19 bindgen requirement that pin exists to avoid.
so the only real verification is the build that runs once this lands on
main.