Skip to content

fix(docker): bump cargo-zigbuild to 0.23.0 so the arm64 leg links again - #245

Merged
henry40408 merged 1 commit into
mainfrom
fix/zigbuild-cortex-a53
Aug 23, 2026
Merged

fix(docker): bump cargo-zigbuild to 0.23.0 so the arm64 leg links again#245
henry40408 merged 1 commit into
mainfrom
fix/zigbuild-cortex-a53

Conversation

@henry40408

Copy link
Copy Markdown
Owner

The 1.98 toolchain bump (#241) is green on every CI check and still breaks the
image: docker.yml fires on tags and pushes to main, not on pull requests, so
the first build to run it was v0.30.1's — and only the arm64 leg failed
(run).

Rust 1.98 passes --fix-cortex-a53-843419 to the linker for aarch64 targets
(rust-lang/rust#155453). Zig's linker rejects unknown arguments outright, so the
wrapper cargo-zigbuild 0.22.3 generates fails with unsupported linker arg: --fix-cortex-a53-843419 and noadd never links for
aarch64-unknown-linux-musl. amd64 is unaffected — the argument is only emitted
for aarch64.

cargo-zigbuild 0.23.0 filters the argument in filter_linker_arg
(rust-cross/cargo-zigbuild#452), alongside the two other arguments it already
dropped for the same reason. The rest of the 0.22.3..0.23.0 range is a
cargo-dist config update, a cargo-options bump, and dependabot commits.

Zig stays on 0.14.1: the fix is in the wrapper, not the linker, and 0.15+ still
brings the libc++-19 bindgen requirement that pin exists to avoid.

⚠️ CI cannot prove this one. No workflow builds the image on a pull request,
so the only real verification is the build that runs once this lands on main.

The 1.98 toolchain bump (#241) is green on every CI check and still breaks
the image: `docker.yml` fires on tags and pushes to `main`, not on pull
requests, so the first build to run it was v0.30.1's — and only the arm64
leg failed.

Rust 1.98 passes `--fix-cortex-a53-843419` to the linker for aarch64 targets
(rust-lang/rust#155453). Zig's linker rejects unknown arguments outright, so
the wrapper cargo-zigbuild 0.22.3 generates fails with `unsupported linker
arg: --fix-cortex-a53-843419` and `noadd` never links for
aarch64-unknown-linux-musl. amd64 is unaffected — the argument is only
emitted for aarch64.

cargo-zigbuild 0.23.0 filters the argument in `filter_linker_arg`
(rust-cross/cargo-zigbuild#452), alongside the two other arguments it already
dropped for the same reason. The rest of the 0.22.3..0.23.0 range is a
cargo-dist config update, a cargo-options bump, and dependabot commits.

Zig stays on 0.14.1: the fix is in the wrapper, not the linker, and 0.15+
still brings the libc++-19 bindgen requirement this pin exists to avoid.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RLF7TP74kER7Wcx8Th33qc
@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.82%. Comparing base (e54a942) to head (79d2251).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   90.82%   90.82%           
=======================================
  Files          29       29           
  Lines       10647    10647           
=======================================
  Hits         9670     9670           
  Misses        977      977           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@henry40408
henry40408 merged commit 10f48c8 into main Aug 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant