Conversation
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
fix unit tests when enabling simple fees Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
…/suites/hip1261/utils/SimpleFeesScheduleConstantsInUsd.java Co-authored-by: Matt Hess <matt.hess@swirldslabs.com> Signed-off-by: Josh Marinacci <276938+joshmarinacci@users.noreply.github.com>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
…' into simplefees-consensus-tests-fixes
fix TopicCustomFeeSubmitMessageTest add new variant with the allowed diff parameters Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
fix token services tests Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
|
Merging to
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #23409 +/- ##
=========================================
Coverage 77.96% 77.97%
- Complexity 23483 23489 +6
=========================================
Files 2460 2461 +1
Lines 91890 91893 +3
Branches 9784 9784
=========================================
+ Hits 71645 71656 +11
+ Misses 16624 16620 -4
+ Partials 3621 3617 -4 see 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
| cryptoCreate(FREEZE_ADMIN), | ||
| cryptoCreate(ADDRESS_BOOK_CONTROL), | ||
| cryptoCreate(EXCHANGE_RATE_CONTROL), | ||
| cryptoCreate(FEE_SCHEDULE_CONTROL), |
There was a problem hiding this comment.
I don't understand, how does this help?
There was a problem hiding this comment.
Without these the test fails with INSUFFICIENT_PAYER_BALANCE instead of AUTHORIZATION_FAILED, when running under simple fees.
There was a problem hiding this comment.
It is strange that the missing accounts fail with INSUFFICIENT_PAYER_BALANCE instead of something more accurate like NO_SUCH_USER.
Description:
Related issue(s):
Fixes #
Notes for reviewer:
Checklist