Skip to content

fix: PriviledgeOpsTest#23409

Open
joshmarinacci wants to merge 27 commits intomainfrom
simplefees-moar-fixes
Open

fix: PriviledgeOpsTest#23409
joshmarinacci wants to merge 27 commits intomainfrom
simplefees-moar-fixes

Conversation

@joshmarinacci
Copy link
Contributor

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

joshmarinacci and others added 24 commits February 5, 2026 09:13
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
fix unit tests when enabling simple fees

Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
…/suites/hip1261/utils/SimpleFeesScheduleConstantsInUsd.java

Co-authored-by: Matt Hess <matt.hess@swirldslabs.com>
Signed-off-by: Josh Marinacci <276938+joshmarinacci@users.noreply.github.com>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
fix TopicCustomFeeSubmitMessageTest
add new variant with the allowed diff parameters

Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
fix token services tests

Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
@joshmarinacci joshmarinacci requested review from a team as code owners February 6, 2026 22:38
@trunk-io
Copy link

trunk-io bot commented Feb 6, 2026

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@lfdt-bot
Copy link

lfdt-bot commented Feb 6, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production
Copy link

codacy-production bot commented Feb 6, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 6561ac11
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6561ac1) Report Missing Report Missing Report Missing
Head commit (4e771e5) 91710 75173 81.97%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#23409) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #23409   +/-   ##
=========================================
  Coverage     77.96%   77.97%           
- Complexity    23483    23489    +6     
=========================================
  Files          2460     2461    +1     
  Lines         91890    91893    +3     
  Branches       9784     9784           
=========================================
+ Hits          71645    71656   +11     
+ Misses        16624    16620    -4     
+ Partials       3621     3617    -4     

see 8 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshmarinacci joshmarinacci changed the title fix: More fixes for Simple Fees fix: PriviledgeOpsTest Feb 9, 2026
@joshmarinacci joshmarinacci self-assigned this Feb 9, 2026
@joshmarinacci joshmarinacci added this to the v0.72 milestone Feb 9, 2026
Comment on lines +79 to +82
cryptoCreate(FREEZE_ADMIN),
cryptoCreate(ADDRESS_BOOK_CONTROL),
cryptoCreate(EXCHANGE_RATE_CONTROL),
cryptoCreate(FEE_SCHEDULE_CONTROL),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand, how does this help?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without these the test fails with INSUFFICIENT_PAYER_BALANCE instead of AUTHORIZATION_FAILED, when running under simple fees.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is strange that the missing accounts fail with INSUFFICIENT_PAYER_BALANCE instead of something more accurate like NO_SUCH_USER.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants