-
Notifications
You must be signed in to change notification settings - Fork 195
fix: PriviledgeOpsTest #23409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joshmarinacci
wants to merge
27
commits into
main
Choose a base branch
from
simplefees-moar-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: PriviledgeOpsTest #23409
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
a53997b
enable simple fees
joshmarinacci 89de6e9
spotless
joshmarinacci 10079d3
Merge branch 'main' into simplefees-consensus-tests-fixes
joshmarinacci 0be9900
improve FeeResult debug output
joshmarinacci b6c2498
spotless
joshmarinacci 86aff88
fix issue
joshmarinacci 82e8d6d
disable simple fees
joshmarinacci ecf6e90
fix file service tests
joshmarinacci 40b7da8
spotless
joshmarinacci 85b8bc1
spotless
joshmarinacci a3bdd00
fixes for TopicCreateSuite
joshmarinacci 80cdeff
Merge branch 'main' into simplefees-consensus-tests-fixes
joshmarinacci 7da617c
Update hedera-node/test-clients/src/main/java/com/hedera/services/bdd…
joshmarinacci 5d3cef4
fix compile error
joshmarinacci 6a18978
turn off simple fees again
joshmarinacci f1f401c
Merge branch 'main' into simplefees-consensus-tests-fixes
joshmarinacci d9b387b
move util function to FeesChargingUtils
joshmarinacci de21579
Merge remote-tracking branch 'origin/simplefees-consensus-tests-fixes…
joshmarinacci c95d1d9
move util function again and rename
joshmarinacci f044b3c
Merge branch 'main' into simplefees-consensus-tests-fixes
joshmarinacci f92e047
Merge branch 'main' into simplefees-consensus-tests-fixes
joshmarinacci 4cb4742
remove duplicated constant
joshmarinacci 8d5778e
add more fee estimation util methods
joshmarinacci 9d4d7a4
fix tests when running under simple fees
joshmarinacci 4c00014
Merge branch 'main' into simplefees-moar-fixes
joshmarinacci 11db33d
Merge branch 'main' into simplefees-moar-fixes
joshmarinacci 4e771e5
Merge branch 'main' into simplefees-moar-fixes
joshmarinacci File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand, how does this help?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without these the test fails with INSUFFICIENT_PAYER_BALANCE instead of AUTHORIZATION_FAILED, when running under simple fees.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is strange that the missing accounts fail with INSUFFICIENT_PAYER_BALANCE instead of something more accurate like NO_SUCH_USER.