Skip to content

feat: 24023 Added a config property to disable periodic snapshots#24024

Open
imalygin wants to merge 1 commit intorelease/0.72from
24023-no-periodic-snapshot-mod-cherry-pick
Open

feat: 24023 Added a config property to disable periodic snapshots#24024
imalygin wants to merge 1 commit intorelease/0.72from
24023-no-periodic-snapshot-mod-cherry-pick

Conversation

@imalygin
Copy link
Contributor

@imalygin imalygin commented Mar 4, 2026

Description:

This is a cherry-pick of #23932 to release/0.72

(cherry picked from commit 18e8c35)

Related issue(s):

Fixes #24023

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@imalygin imalygin added this to the v0.72 milestone Mar 4, 2026
@imalygin imalygin self-assigned this Mar 4, 2026
@imalygin imalygin requested a review from a team as a code owner March 4, 2026 20:11
@imalygin imalygin requested a review from timo0 March 4, 2026 20:11
@trunk-io
Copy link

trunk-io bot commented Mar 4, 2026

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@lfdt-bot
Copy link

lfdt-bot commented Mar 4, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...atform/components/DefaultSavedStateController.java 75.00% 0 Missing and 1 partial ⚠️

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.72   #24024      +/-   ##
==================================================
- Coverage           78.24%   78.23%   -0.02%     
  Complexity          11654    11654              
==================================================
  Files                2461     2461              
  Lines               92528    92530       +2     
  Branches             9846     9848       +2     
==================================================
- Hits                72402    72393       -9     
- Misses              16468    16477       +9     
- Partials             3658     3660       +2     
Files with missing lines Coverage Δ Complexity Δ
.../org/hiero/consensus/state/config/StateConfig.java 50.00% <ø> (ø) 2.00 <0.00> (ø)
...atform/components/DefaultSavedStateController.java 77.14% <75.00%> (-1.65%) 0.00 <0.00> (ø)

... and 11 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (77ea5b2) 92431 76011 82.24%
Head commit (371d12e) 92433 (+2) 76004 (-7) 82.23% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#24024) 4 4 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

timo0
timo0 previously approved these changes Mar 4, 2026
@imalygin imalygin changed the base branch from main to release/0.72 March 5, 2026 18:25
@imalygin imalygin dismissed timo0’s stale review March 5, 2026 18:25

The base branch was changed.

@imalygin imalygin requested a review from timo0 March 5, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Added a config property to disable periodic snapshots - cherry-pick to 0.72

3 participants