Skip to content

feat: 24023 Added a config property to disable periodic snapshots #24024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imalygin wants to merge 1 commit into
base: release/0.72
Choose a base branch
from
+10 −5
Open

feat: 24023 Added a config property to disable periodic snapshots #24024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions platform-sdk/consensus-state/src/main/java/org/hiero/consensus/state/config/StateConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,11 @@
* careful enabling this network wide. If this is enabled and all states on disk
* have deserialization bugs, then all nodes will delete all state copies and the
* network will restart from genesis.
* @param validateInitialState If false then do not do ISS validation on the state loaded from disk at startup.
* @param validateInitialState If false, then do not do ISS validation on the state loaded from disk at startup.
* This should always be enabled in production environments. Disabling initial
* state validation is intended to be a test-only feature.
* @param periodicSnapshotsEnabled If true, then create periodic snapshots of the signed state.
*
*/
@ConfigData("state")
public record StateConfig(
Expand All @@ -81,7 +83,8 @@ public record StateConfig(
@ConfigProperty(defaultValue = "false") boolean stateHistoryEnabled,
@ConfigProperty(defaultValue = "false") boolean debugStackTracesEnabled,
@ConfigProperty(defaultValue = "false") boolean deleteInvalidStateFiles,
@ConfigProperty(defaultValue = "true") boolean validateInitialState) {
@ConfigProperty(defaultValue = "true") boolean validateInitialState,
@ConfigProperty(defaultValue = "true") boolean periodicSnapshotsEnabled) {

/**
* Get the main class name that should be used for signed states.
Expand Down
8 changes: 5 additions & 3 deletions ...tform-core/src/main/java/com/swirlds/platform/components/DefaultSavedStateController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,13 @@ private StateToDiskReason shouldSaveToDisk(
return FIRST_ROUND_AFTER_GENESIS;
}

if ((signedState.getConsensusTimestamp().getEpochSecond() / saveStatePeriod)
> (previousTimestamp.getEpochSecond() / saveStatePeriod)) {
final boolean periodicSnapshotsEnabled = stateConfig.periodicSnapshotsEnabled();
if (periodicSnapshotsEnabled
&& (signedState.getConsensusTimestamp().getEpochSecond() / saveStatePeriod)
> (previousTimestamp.getEpochSecond() / saveStatePeriod)) {
return PERIODIC_SNAPSHOT;
} else {
// the period hasn't yet elapsed
// the period hasn't yet elapsed or periodic snapshots are disabled
return null;
}
}
Expand Down
Loading