fix: delegate coverage alias to shared test runner

[mendezr]

Summary

• Route test:coverage through scripts/run-tests.mjs, sharing the 99/96/98 thresholds and test/** exclusion with npm test.
• Add a regression guard requiring the shared runner without inline coverage flags.

Fixes #268

Validation

• Confirmed the regression test fails against the old alias.
• npm test: 347 passed on Node 24.22.0.
• npm run test:coverage: 347 passed; all coverage thresholds met.
• git diff --check passed.
• Podman is not installed in this environment; validation ran locally.

— hive: backend=pi model=openai-codex/gpt-6.1-sol

---

🐝 Hive Agent: contributor | SHA: 3ff980d

[github-actions]

Welcome to the Hive Commons community!

Thanks for opening your first PR here! We're excited to have you contributing.

Before merge, please ensure:

• DCO Sign-off — All commits signed with git commit -s (DCO)
• PR Title — Starts with an emoji: ✨ feature | 🐛 bug fix | 📖 docs | 🌱 infra/tests | ⚠️ breaking

A maintainer will review your PR soon. Hope you have a great time here!

[hivecommons-hive]

3ff980d

⚠️ Sentinel alert — maintainer review required

Hive flagged this PR (author @mendezr, head 3ff980d95084) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

• sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
  • package.json

Hive added the sentinel-alert label. While it is present, Hive will not approve this PR, apply LGTM/approval labels, or merge it through any auto-merge lane. Remove the label once reviewed; Hive will not re-apply it unless new commits are pushed. Tune paths and behaviors under sentinel in hive.yaml or the dashboard Security tab.

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1

[hivecommons-hive]

Needs a decision, not a merge:

• the reviewer swarm returned requires_human @e7a3a1f
• reviewer question: @hivecommons/pluk OWNERS should confirm the package.json script change is intended (it moves test:coverage onto the stricter shared runner) and clear the sentinel-alert.
• a sentinel alert is open on this PR
• the automerge lane will not merge this unattended

Head: verdict requires_human @e7a3a1f, 4/4 checks green, DCO yes, sentinel alert, soak 30m0s elapsed.

_{Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge or the merge queue on its own.}

[clubanderson]

Maintainer review of the sentinel flag: the package.json change only delegates test:coverage to the existing shared runner (scripts/run-tests.mjs) and adds a test for it — intended. Clearing sentinel-alert.

[kubestellar-prow]

LGTM label has been added.

Details

Git tree hash: 154770b4bbabe716233e617d2f0a2e9d13d0b1d8

[hivecommons-hive]

4c1b359

⚠️ Sentinel alert — maintainer review required

Hive flagged this PR (author @mendezr, head 4c1b359e0ed1) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

• sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
  • package.json

Hive added the sentinel-alert label. While it is present, Hive will not approve this PR, apply LGTM/approval labels, or merge it through any auto-merge lane. Remove the label once reviewed; Hive will not re-apply it unless new commits are pushed. Tune paths and behaviors under sentinel in hive.yaml or the dashboard Security tab.

[hivecommons-hive]

Routing only — the change is unchanged since the maintainer approval.

Head 4c1b359 and e7a3a1f are both Merge branch 'main' into fix/268-coverage-alias; git diff main...4c1b359 is byte-identical to the diff at the approved head 3ff980d (only package.json + test/run-tests-runner.test.js, same hunks). The sentinel re-fired on the merge commit, not on new content.

Re-verified against the tree: the new alias npm run build && node scripts/run-tests.mjs matches what CONTRIBUTING.md:23 already documents (“npm run test:coverage is an explicit alias for the same check”), and scripts/run-tests.mjs:17-23 applies the 99/96/98 thresholds with test/** excluded; engines.node >=22 means the Node-20 no-coverage fallback is never reached. Looks correct to me.

@clubanderson: the only action needed is clearing sentinel-alert again. I have not changed any labels.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Needs a decision, not a merge:

• the reviewer swarm returned requires_human @4c1b359
• reviewer summary: correctness requires human: package.json test:coverage now runs the same command as test (node scripts/run-tests.mjs). The shared runner (scripts/run-tests.mjs:17-28) applies stricter thresholds (99/96/98 vs the removed 98/93/97) on Node >= 22 but drops all coverage flags on Node < 22, so on Node 20 test:coverage silently runs without any coverage gate where it previously failed on unknown flags. New test asserts the script string. Not a defect in the diff, but a maintainer should confirm the Node<22 fallthrough is acceptable for a script named test:coverage.
• reviewer summary: security requires human: PR carries the sentinel-alert label and two hive-sentinel comments (heads 3ff980d and 4c1b359) because it edits a package.json script. The change removes inline coverage flags and delegates to the in-repo runner; no new commands, network, or permissions. Routed to a human per sentinel policy; the open needs-decision comment already names @hivecommons/pluk OWNERS.
• a sentinel alert is open on this PR
• the automerge lane will not merge this unattended

Head: verdict requires_human @4c1b359, 4/4 checks green, DCO yes, sentinel alert, soak 30m0s elapsed.

_{Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge or the merge queue on its own.}

[clubanderson]

Hub-admin review: the reviewer's only concern (Node < 22 would run test:coverage without a coverage gate) is moot — package.json declares "engines": { "node": ">=22" } and CI runs 22/24/26, so Node 20 is outside the supported range. On every supported Node the alias now enforces the stricter shared 99/96/98 thresholds with the test/** exclusion, which is exactly what #268 asked for. Pure test plumbing, no policy change; sentinel-alert is just the package.json sensitive-path heuristic. Branch was BEHIND — updated from main; merging once CI re-runs green.

/lgtm
/approve

[kubestellar-prow]

LGTM label has been added.

Details

Git tree hash: 4a1d71e3e0072393fac7bcb03b88a9cc940f22b2

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clubanderson

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88