Skip to content

fix: delegate coverage alias to shared test runner #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clubanderson merged 4 commits into from
Oct 19, 2026
Merged

fix: delegate coverage alias to shared test runner #269

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ff980d
fix: delegate coverage alias to shared test runner
mendezr Oct 17, 2026
e7a3a1f
Merge branch 'main' into fix/268-coverage-alias
hivecommons-hive[bot] Oct 17, 2026
4c1b359
Merge branch 'main' into fix/268-coverage-alias
hivecommons-hive[bot] Oct 18, 2026
b19d07b
Merge branch 'main' into fix/268-coverage-alias
clubanderson Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"scripts": {
"build": "tsc",
"test": "npm run build && node scripts/run-tests.mjs",
"test:coverage": "npm run build && node --test --experimental-test-coverage --test-coverage-lines=98 --test-coverage-branches=93 --test-coverage-functions=97 test/*.test.js",
"test:coverage": "npm run build && node scripts/run-tests.mjs",
"prepublishOnly": "npm run build"
},
"keywords": [
Expand Down
6 changes: 6 additions & 0 deletions test/run-tests-runner.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ test('CONTRIBUTING.md documents the thresholds COVERAGE_FLAGS actually enforce',
assert.match(doc, new RegExp(`lines ${pct('lines')}, branches ${pct('branches')}, functions ${pct('functions')}`));
});

test('test:coverage delegates to the shared runner without inline coverage flags', () => {
const { scripts } = JSON.parse(readFileSync(join(process.cwd(), 'package.json'), 'utf-8'));
assert.equal(scripts['test:coverage'], 'npm run build && node scripts/run-tests.mjs');
assert.doesNotMatch(scripts['test:coverage'], /--(?:experimental-test-coverage|test-coverage-)/);
});

test('listTestFiles returns only sorted *.test.js entries', () => {
const dir = mkdtempSync(join(tmpdir(), 'pluk-run-tests-'));
try {
Expand Down
Loading