Fix kontext finetune issue when batch size >1 #11921
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Problem
Training fails with shape mismatch when using custom instance prompts and
batch_size > 1
due to partial batches from the dataloader.Solution
Set
drop_last=True
inBucketBatchSampler
to ensure consistent batch sizes during training. This prevents shape mismatch errors when the last batch is smaller than the specified batch size.Testing
Verified the fix resolves the shape mismatch error by running training with custom instance prompts and
batch_size > 1
. No shape mismatch occurs after this change.Fixes # (issue)
Before submitting
Who can review?
Anyone in the community is free to review the PR once the tests have passed.
For this example script and dataloader logic, relevant reviewers could be: