Skip to content

fix exclude_keys to support smolvla #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

zuoxingdong
Copy link
Contributor

@zuoxingdong zuoxingdong commented Jun 4, 2025

What this does

This PR adds exclude_keys to populate_queues for supporting smolvla action selection: https://github.com/huggingface/lerobot/blob/main/lerobot/common/policies/smolvla/modeling_smolvla.py#L285

cc: @danaaubakirova @Cadene

How it was tested

Explain/show how you tested your changes.

Examples:

  • Added test_something in tests/test_stuff.py.
  • Added new_feature and checked that training converges with policy X on dataset/environment Y.
  • Optimized some_function, it now runs X times faster than previously.

How to checkout & try? (for the reviewer)

Provide a simple way for the reviewer to try out your changes.

Examples:

pytest -sx tests/test_stuff.py::test_something
python lerobot/scripts/train.py --some.option=true

SECTION TO REMOVE BEFORE SUBMITTING YOUR PR

Note: Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR. Try to avoid tagging more than 3 people.

Note: Before submitting this PR, please read the contributor guideline.

@AdilZouitine AdilZouitine added the enhancement Suggestions for new features or improvements label Jun 5, 2025
@aliberts
Copy link
Collaborator

aliberts commented Jun 6, 2025

Thank you!
I'm closing this since it's a duplicate of #1208

@aliberts aliberts marked this as a duplicate of #1208 Jun 6, 2025
@aliberts aliberts closed this Jun 6, 2025
ZhuYaoHui1998 added a commit to ZhuYaoHui1998/lerobot that referenced this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Suggestions for new features or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants