Skip to content

Fix some code annotation typos. #37102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

zhanluxianshen
Copy link
Contributor

@zhanluxianshen zhanluxianshen commented Mar 29, 2025

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@github-actions github-actions bot marked this pull request as draft March 29, 2025 12:53
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@zhanluxianshen zhanluxianshen marked this pull request as ready for review March 29, 2025 12:53
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, LGTM! Please wait a day or so and then rebase, and hopefully the CI issues will be resolved

@zhanluxianshen
Copy link
Contributor Author

Ok, i will rebase later。
thanks review。

@zhanluxianshen zhanluxianshen force-pushed the fix-notes-typos branch 2 times, most recently from d6dfc59 to cd1ed71 Compare April 1, 2025 10:47
Signed-off-by: zhanluxianshen <[email protected]>
@Rocketknight1 Rocketknight1 merged commit c94c6ed into huggingface:main Apr 2, 2025
18 checks passed
@Rocketknight1
Copy link
Member

Merging, and thank you for the PR!

zucchini-nlp pushed a commit to BakerBunker/transformers that referenced this pull request Apr 2, 2025
@zhanluxianshen zhanluxianshen deleted the fix-notes-typos branch April 3, 2025 00:45
@zhanluxianshen
Copy link
Contributor Author

Thanks.

duanjunwen pushed a commit to duanjunwen/transformers that referenced this pull request Apr 3, 2025
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants