-
Notifications
You must be signed in to change notification settings - Fork 167
v6.0 #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
v6.0 #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repository owner
deleted a comment from
coveralls
Jan 18, 2018
1 similar comment
Merged
…array so that the suggestions list can be displayed without entering a query
…estions list is always in sync with the current query
… remove unnecessary logic
Fix default options state
This re-implements the delimiterChars option as an array of literal characters. When the entered query increases in length the last character is checked against this list. This replaces the use of keyboard events to find out which key was pressed because key mapping does not always occur when entry is made by a virtual or soft keyboard.
Delimiters for soft keyboards
…evel props change In v6 I refactored how suggestions were filtered to avoid the use of `componentWillReceiveProps()`. However, this meant the suggestions list would only rerender on initial mount and `onInput` and not when the `suggestions` prop changed. This refactors the filtered suggestions to be updated using the `getDerivedStateFromProps()` static method. Fixes #209
…change Refactor filtered suggestions to ensure list updates on top-level props change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes tracked in #106