Skip to content

Small fix to compile with gcc 4.9#7

Open
slosar wants to merge 1 commit intoigmhub:masterfrom
slosar:uint_fix
Open

Small fix to compile with gcc 4.9#7
slosar wants to merge 1 commit intoigmhub:masterfrom
slosar:uint_fix

Conversation

@slosar
Copy link
Contributor

@slosar slosar commented Aug 16, 2015

No description provided.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if <stdint> works also, since the .h is normally not required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, on my machine you do need .h. Weird, isn't it?

anže

On Sun, 16 Aug 2015, dkirkby wrote:

@@ -11,6 +11,7 @@

#include
#include
+#include <stdint.h>

Can you check if works also, since the .h is normally not required.


Reply to this email directly or view it on GitHub:
https://github.com/deepzot/likely/pull/7/files#r37148585

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant <cstdint>. You are generally supposed to include <cxxx> instead of <xxx.h> in C++, with the only difference being that the C++ version wraps everything in a namespace, to avoid polluting the global namespace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm, it works but requires compiler option to enable c++11, e.g.

/usr/include/c++/4.9/bits/c++0x_warning.h:32:2: error: #error This file
requires compiler and library support for the ISO C++ 2011 standard. This
support is currently experimental, and must be enabled with the -std=c++11
or -std=gnu++11 compiler options.
#error This file requires compiler and library support for the
...

anže

On Sat, 22 Aug 2015, dkirkby wrote:

@@ -11,6 +11,7 @@

#include
#include
+#include <stdint.h>

Sorry, I meant <cstdint>. You are generally supposed to include <cxxx> instead of <xxx.h> in C++, with the only difference being that the C++ version wraps everything in a namespace, to avoid polluting the global namespace.


Reply to this email directly or view it on GitHub:
https://github.com/deepzot/likely/pull/7/files#r37701122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants