feat: basic test helper methods for inserting data into postgres and es#542
Open
kfc35 wants to merge 2 commits intoinaturalist:mainfrom
Open
feat: basic test helper methods for inserting data into postgres and es#542kfc35 wants to merge 2 commits intoinaturalist:mainfrom
kfc35 wants to merge 2 commits intoinaturalist:mainfrom
Conversation
kfc35
commented
Oct 10, 2025
| expect( res.body.results.length ).to.eq( 1 ); | ||
| expect( res.body.results.map( r => r.id ) ).to.contain( observationES.id ); | ||
| } ).expect( 200 ); | ||
| } finally { |
Author
There was a problem hiding this comment.
if a test fails, it throws, so this finally block ensures the test specific data is wiped
kfc35
force-pushed
the
140-basic-test-helpers
branch
from
6ed529d to
ab4ecfd
Compare
kfc35
force-pushed
the
140-basic-test-helpers
branch
from
ab4ecfd to
9effe36
Compare
kfc35
force-pushed
the
140-basic-test-helpers
branch
from
9effe36 to
e074153
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains some VERY basic test_helper methods for inserting data into postgres and es. Personally I am wanting for more… like setting up some transactional testing framework of a sort within a test… but this is a small step towards something. Having specific test data closer to tests instead of having to search for them in a big fixture file is better in my opinion, but I will not be offended if this pull is rejected if there is a desire for something more comprehensive. One can use
before/beforeEach/after/afterEachto do inserts and deletes for a suite of tests in the meantime.The associated tests serves as examples of usage, and both are related to issues I am working on, so they are perfectly fine to include into the codebase.
Helps with #140
I noticed the tests I wrote are a little on the slower side, though, presumably because of the inserts and deletes (30-70ms, yellow range usually).
I’m admittedly not an expert at async/await so feel free to look at the usage more critically