Gemspec and Ruby update

[FlexonyoPizza]

Summary

• Disabled 'AccessModifierDeclarations' cop in 'rubocop.yml'

• RuboCop style autocorrections including:
  -RedundantParenthesis
  -ZeroLengthPredicate
  -HashEachMethods
  -MultipleComparison
  -RedundantRegexpEscape

[ljtucker]

why delete rubocop entirely here?

[karlnaden]

Many ways to slice this, but planning to be consistent with inferno_core, which has rubocop as a development and test dependency in the Gemfile, not a development_dependency in the gemspec. So removing keeps it consistent.

[FlexonyoPizza]

In the future, we might consider parallel version 2.0 instead of 1.26 for both fhir_models and inferno-core? 1.26 supports ruby versions 2.7 and above. 2.0 supports ruby 3.3, which is the ruby version inferno-core uses right now.

[karlnaden]

in addition to the one question below, can you send me details (or better, put into the PR) how you tested this in inferno-core and test kits. This is a core component, so want to make sure we have multiple eyes on it before releasing a gem, even though there's no functional changes.

[karlnaden]

Many ways to slice this, but planning to be consistent with inferno_core, which has rubocop as a development and test dependency in the Gemfile, not a development_dependency in the gemspec. So removing keeps it consistent.

[karlnaden]

Is this needed in general, or only for dev / testing? If only for dev and testing, could it be moved into the development, test group?

[FlexonyoPizza]

parallel is used by rubocop solely for dev/testing, it isnt used at runtime so yes we can definitely move it into the development & test group

[karlnaden]

In the future, we might consider parallel version 2.0 instead of 1.26 for both fhir_models and inferno-core? 1.26 supports ruby versions 2.7 and above. 2.0 supports ruby 3.3, which is the ruby version inferno-core uses right now.

parallel is an indirect dependency, correct, coming from rubocop, which is a development dependency? I don't know that we want or need to drop support for 3.2 on a foundational module like this - no vulnerabilities currently so far as I am aware, so I think keeping the update simpler and keeping the pin at 1.26 is right, but definitely worth considering for the next update.

[FlexonyoPizza]

Prereqs: You need to have a repo with the changes in this PR forked

1. Point fhir_models gem to your inferno-core fork
From your local inferno-core repo, in Gemfile, add a git source override right after "gemspec":

gem 'fhir_models', git: 'https://github.com/Username/fhir_models', branch: 'master'

then install: 'bundle install'

*if bundle install doesnt work, your inferno-core gemlock file may have gems locked to a previous resolution, in that case simply run: bundle update fhir_models

2. Run unit tests
'bundle exec rake spec'

3. Start inferno services and server
'bundle exec inferno services start'
'bundle exec inferno start'

4. Run all execution scripts
In a seperate terminal:
'bundle exec rake execute_scripts:run_all'

[karlnaden]

running one last verification. Make these two non-functional changes and I think we'll be ready to merge

[karlnaden]

since we updated this file, also update .tool-versions to match