[Task #1080] Add locale negotiation

[djordjelacmanovic]

Related issue: #1080

[vr4b4c]

Great contribution 🙇 , I'm interested to hear your thoughts on my suggestions.

[vr4b4c]

I find it odd that we check locale validity here but don't do the same in #setup_locale. Can you please elaborate the decision?

[djordjelacmanovic]

This gem handles I18n::InvalidLocale via rescue_from in InfinumJsonApiSetup::JsonApi::ErrorHandling:

        rescue_from I18n::InvalidLocale do |e|
          render_error(InfinumJsonApiSetup::Error::BadRequest.new(message: e.to_s))
        end

if we add localised error rendering here and render an invalid locale we get an error again.

However, in the latest commit this mixin will handle the invalid locale gracefully and respond with a HTTP 400 (default) or fallback to I18n.default_locale. Thus, the validity check was also removed from error rendering.

[vr4b4c]

Can you check out https://github.com/cyril/accept_language.rb and see if it makes sense to integrate that dependency as well?

[djordjelacmanovic]

I've considered this gem but I took the option of not adding another dependency, instead using the simpler approach similar to what we have elsewhere.

If we're cool with another dependency for a more feature-full parser I'm all for it 👍🏻

[vr4b4c]

accept_language seems lightweight, only other dependency is from standard library practically, bigdecimal. It gets a pass from me but I'm leaving the decision to you.

[djordjelacmanovic]

accept_language was added

[djordjelacmanovic]

Symlink was broken

[djordjelacmanovic]

Same as above