fix: prevent keyboard handlers stack mutation during iteration #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Problem
The keyboard handlers stack gets permanently mutated during iteration, causing unpredictable behavior on subsequent key presses.
Root Cause
The .reverse() method modifies the array in-place, so after the first keydown event, all handlers are permanently stored in reverse order, breaking the expected execution sequence.
Solution
Use array spread to create a copy before reversing:
Additionally, fix handler cleanup to prevent removing wrong handlers:
Impact
Files Changed
hooks/useGlobalKey.ts - Fixed array mutation and cleanup logic