Skip to content

fix: prevent keyboard handlers stack mutation during iteration #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent keyboard handlers stack mutation during iteration #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/hooks/useGlobalKey.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useEffect } from "react";
import { sendGTMEvent } from "@next/third-parties/google";
import { useEffect } from "react";

type KeyboardKey = KeyboardEvent["key"];

Expand Down Expand Up @@ -28,7 +28,7 @@ export function useGlobalKeyCallback() {
if (!(lowerKey in allHandlersStacks)) return;
if (shouldHandleAsNativeEvent(event)) return;
const handlersStack = allHandlersStacks[lowerKey];
for (let handler of handlersStack.reverse()) {
for (let handler of [...handlersStack].reverse()) {
if (handler()) {
event.preventDefault();
event.stopPropagation();
Expand Down Expand Up @@ -63,7 +63,9 @@ export const useCallbackOnKey = ({
return () => {
if (!isDisabled) {
const index = allHandlersStacks[lowerKey].indexOf(handler);
allHandlersStacks[lowerKey].splice(index, 1);
if (index > -1) {
allHandlersStacks[lowerKey].splice(index, 1);
}
}
};
}, [key, handler, isDisabled]);
Expand Down