-
Notifications
You must be signed in to change notification settings - Fork 9
fix(cat-gateway): Fix endpoints cardano/assets
and cardano/registrations/cip36
endpoints
#1986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
…-hk/catalyst-voices into fix/assets-endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial Review, more to come
/// The first block we successfully synced. | ||
first_indexed_block: Option<Point>, | ||
/// Is the starting point immutable? (True = immutable, false = don't know.) | ||
first_is_immutable: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remove this status
/// The last block we successfully synced. | ||
last_indexed_block: Option<Point>, | ||
/// Is the ending point immutable? (True = immutable, false = don't know.) | ||
last_is_immutable: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remove this status
write!( | ||
f, | ||
", first_indexed_block: {first}{}", | ||
if self.first_is_immutable { ":I" } else { "" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reintroduce this information to the display.
first_indexed_block: None, | ||
first_is_immutable: false, | ||
last_indexed_block: None, | ||
last_is_immutable: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reintroduce this state
done.first_indexed_block = first; | ||
done.first_is_immutable = first_immutable; | ||
done.last_indexed_block = last; | ||
done.last_is_immutable = last_immutable; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set this state
Description