Skip to content

fix(cat-gateway): Fix endpoints cardano/assets and cardano/registrations/cip36 endpoints #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 108 commits into
base: main
Choose a base branch
from

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Mar 9, 2025

Description

@Mr-Leshiy Mr-Leshiy requested a review from bkioshn March 25, 2025 19:12
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial Review, more to come

/// The first block we successfully synced.
first_indexed_block: Option<Point>,
/// Is the starting point immutable? (True = immutable, false = don't know.)
first_is_immutable: bool,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove this status

/// The last block we successfully synced.
last_indexed_block: Option<Point>,
/// Is the ending point immutable? (True = immutable, false = don't know.)
last_is_immutable: bool,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove this status

write!(
f,
", first_indexed_block: {first}{}",
if self.first_is_immutable { ":I" } else { "" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reintroduce this information to the display.

first_indexed_block: None,
first_is_immutable: false,
last_indexed_block: None,
last_is_immutable: false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reintroduce this state

done.first_indexed_block = first;
done.first_is_immutable = first_immutable;
done.last_indexed_block = last;
done.last_is_immutable = last_immutable;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set this state

@github-project-automation github-project-automation bot moved this from New to 🔖 Ready in Catalyst Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet PR is not ready to be merged yet
Projects
Status: 🔖 Ready
Development

Successfully merging this pull request may close these issues.

5 participants