Skip to content

fix top menu feedback on mobile #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2025
Merged

fix top menu feedback on mobile #157

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
50178ab
fix top menu feedback
mustafa-sayyed Oct 12, 2025
c0fb2ec
fix: unify active menu item styles for better consistency
mustafa-sayyed Oct 20, 2025
273c336
fix: remove identical styling
mustafa-sayyed Oct 22, 2025
a147f72
run formatting
Anca2022 Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 8 additions & 15 deletions src/components/pages/FoundationHeader.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,14 @@ import ExternalIcon from "../../../public/img/icon-external.svg";
margin-inline-start: var(--space-2xs);
}

.menu-item--level-1 > .is-active,
.menu-item--level-2 > .is-active {
text-decoration: underline;
text-decoration-color: currentColor;
text-decoration-thickness: 2px;
text-underline-offset: 8px;
}

@media screen and (max-width: 479px) {
.site-links-wrapper {
width: 100%;
Expand Down Expand Up @@ -316,14 +324,6 @@ import ExternalIcon from "../../../public/img/icon-external.svg";
display: block;
}

.menu-item--level-1 > .is-active {
border-inline-start: 2px solid var(--color-header-accent);
}

.menu-item--level-2 > .is-active {
text-decoration: underline;
}

.switch-link:hover {
background-color: var(--color-header-accent);
}
Expand Down Expand Up @@ -454,13 +454,6 @@ import ExternalIcon from "../../../public/img/icon-external.svg";
display: none;
}

.menu-item--level-1 > .is-active,
.menu-item--level-2 > .is-active {
text-decoration: underline;
text-decoration-color: currentColor;
text-decoration-thickness: 2px;
text-underline-offset: 8px;
}
}
</style>

Expand Down
Loading