-
Notifications
You must be signed in to change notification settings - Fork 4
fix top menu feedback on mobile #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| display: block; | ||
| } | ||
|
|
||
| .menu-item--level-1 > .is-active { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CSS property values for the mobile media query that match the ones on the main interledger.org website are the following (and are identical to those for desktop):
text-decoration-thickness: 2px;
text-underline-offset: 8px;
To avoid repetition, consider moving these shared rules outside the media query.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, Thanks @Anca2022, have made the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is on interledger.org/developers (styled at 5px underline-offset):

This is on interledger.org/open-standards (styled at 8px underline-offset) - this is what we want to replicate:

As I mentioned previously, on mobile the values are the same as on desktop:
text-decoration-thickness: 2px;
text-underline-offset: 8px;
Anca2022
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Thank you :D
PR Checklist
Summary
Now the UI looks like this
