fix: add pnpm allowBuilds config#181
Conversation
5b2a30c to
61cb2a3
Compare
| allowBuilds: | ||
| '@fortawesome/fontawesome-free': false | ||
| '@parcel/watcher': false | ||
| '@swc/core': true |
There was a problem hiding this comment.
Question: What does this build script do, is it needed?
There was a problem hiding this comment.
I tested locally without allowing the postinstall script, and the build still works for me.
The script looks like it only validates the native SWC binding and installs @swc/wasm as a fallback if needed.
I kept it allowed in case I am not aware of some edge cases for it, but I'm fine disabling it.
There was a problem hiding this comment.
Thanks for checking!
I've also not encountered any issues with all postinstall/build scripts being disabled so far; sounds like this is only relevant for other CPU architectures, e.g. if somebody wants to install InvenioRDM on ARM?
If so, then for the sake of compatibility we could leave it enabled, or for the sake of security we could disable the build script; I'm fine with either but slightly lean towards the latter.
Ping @slint @ntarocco your thoughts?
There was a problem hiding this comment.
Yes, I'm on Apple Silicon ARM. Since everything works with the script disabled on ARM as well, I went ahead and disabled it. If we discover a platform-specific issue later, we can always re-enable it.
61cb2a3 to
e09c2fa
Compare
* Specify build allowances for Font Awesome, Parcel, and SWC. * set strictDepBuilds to false see: https://pnpm.io/settings#strictdepbuilds
e09c2fa to
add091a
Compare
❤️ Thank you for your contribution!
Description
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: