Skip to content

fix: add pnpm allowBuilds config#181

Merged
max-moser merged 1 commit into
inveniosoftware:masterfrom
Samk13:fix-missing-allow-build
Jun 19, 2026
Merged

fix: add pnpm allowBuilds config#181
max-moser merged 1 commit into
inveniosoftware:masterfrom
Samk13:fix-missing-allow-build

Conversation

@Samk13

@Samk13 Samk13 commented May 3, 2026

Copy link
Copy Markdown
Member

❤️ Thank you for your contribution!

Description

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@Samk13 Samk13 added this to v14 May 3, 2026
Comment thread invenio_assets/assets/pnpm-workspace.yaml Outdated
@Samk13
Samk13 force-pushed the fix-missing-allow-build branch from 5b2a30c to 61cb2a3 Compare June 1, 2026 18:16
@Samk13 Samk13 moved this to 👀 In review in v14 Jun 2, 2026
allowBuilds:
'@fortawesome/fontawesome-free': false
'@parcel/watcher': false
'@swc/core': true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: What does this build script do, is it needed?

@Samk13 Samk13 Jun 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally without allowing the postinstall script, and the build still works for me.

The script looks like it only validates the native SWC binding and installs @swc/wasm as a fallback if needed.
I kept it allowed in case I am not aware of some edge cases for it, but I'm fine disabling it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking!
I've also not encountered any issues with all postinstall/build scripts being disabled so far; sounds like this is only relevant for other CPU architectures, e.g. if somebody wants to install InvenioRDM on ARM?

If so, then for the sake of compatibility we could leave it enabled, or for the sake of security we could disable the build script; I'm fine with either but slightly lean towards the latter.
Ping @slint @ntarocco your thoughts?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Samk13 are you using an ARM based CPU?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm on Apple Silicon ARM. Since everything works with the script disabled on ARM as well, I went ahead and disabled it. If we discover a platform-specific issue later, we can always re-enable it.

@Samk13
Samk13 force-pushed the fix-missing-allow-build branch from 61cb2a3 to e09c2fa Compare June 19, 2026 13:32
* Specify build allowances for Font Awesome, Parcel, and SWC.
* set strictDepBuilds to false see:
https://pnpm.io/settings#strictdepbuilds
@Samk13
Samk13 force-pushed the fix-missing-allow-build branch from e09c2fa to add091a Compare June 19, 2026 13:32
@max-moser
max-moser merged commit 818e254 into inveniosoftware:master Jun 19, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to To release 🤖 in v14 Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To release 🤖

Development

Successfully merging this pull request may close these issues.

installation: frontend assets install fails with pnpm 11

4 participants