Next.js SSR Hydration with Children #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-bromann
requested review from
gnbm and
tanner-reits
and removed request for
a team
christian-bromann
changed the title
14 tasks
tanner-reits
reviewed
Aug 9, 2024
Comment on lines
+16
to
+17
| {/* the following space makes the hydration error go away */} | ||
| {' '} |
There was a problem hiding this comment.
This a limitation we need to call out anywhere?
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an experimental enhancement to #445 which considers the light DOM when serializing Stencil components. We've experienced that a Stencil component may consider the light DOM for certain rendering conditions, e.g. add style properties or class names to a host component if the light DOM contains a certain slot.
You can use this dev build
@stencil/[email protected]for testing purposes. Any feedback is much appreciated!