Adds option to define the concatenation dimension in the ObservationManager and change counter update in CommandManager
#2393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascal-roth
requested review from
jsmith-bdai,
Mayankm96 and
kellyguo11
as code owners
|
@pascal-roth what do you think of this compared to (or in addition to): #1958 |
Mayankm96
reviewed
May 11, 2025
Mayankm96
reviewed
May 11, 2025
Mayankm96
reviewed
May 11, 2025
Mayankm96
reviewed
May 11, 2025
Co-authored-by: Mayank Mittal <[email protected]> Signed-off-by: Pascal Roth <[email protected]>
Co-authored-by: Mayank Mittal <[email protected]> Signed-off-by: Pascal Roth <[email protected]>
Co-authored-by: Mayank Mittal <[email protected]> Signed-off-by: Pascal Roth <[email protected]>
|
@kellyguo11 and @jsmith-bdai this also fixes the |
Signed-off-by: Kelly Guo <[email protected]>
Signed-off-by: Kelly Guo <[email protected]>
Signed-off-by: Kelly Guo <[email protected]>
Signed-off-by: Kelly Guo <[email protected]>
yrh012
pushed a commit
to aica-technology/isaac-lab
that referenced
this pull request
Jun 16, 2025
…Manager` and change counter update in `CommandManager` (isaac-sim#2393) # Description Added support for concatenation of observations along different dimensions in `ObservationManager`. Updates the position where the command counter is increased to allow checking for reset environments in the resample call of the `CommandManager` ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Pascal Roth <[email protected]> Signed-off-by: Kelly Guo <[email protected]> Signed-off-by: Kelly Guo <[email protected]> Co-authored-by: Mayank Mittal <[email protected]> Co-authored-by: Kelly Guo <[email protected]> Co-authored-by: Kelly Guo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for concatenation of observations along different dimensions in
ObservationManager.Updates the position where the command counter is increased to allow checking for reset environments in the resample call of the
CommandManagerType of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there