Skip to content

Adds option to define the concatenation dimension in the ObservationManager and change counter update in CommandManager #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pascal-roth
Copy link
Collaborator

@pascal-roth pascal-roth commented Apr 28, 2025

Description

Added support for concatenation of observations along different dimensions in ObservationManager.

Updates the position where the command counter is increased to allow checking for reset environments in the resample call of the CommandManager

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@pascal-roth pascal-roth self-assigned this Apr 28, 2025
@pascal-roth pascal-roth added the enhancement New feature or request label Apr 28, 2025
@jtigue-bdai
Copy link
Collaborator

@pascal-roth what do you think of this compared to (or in addition to): #1958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants