Fix/replace slices with string #2571
Open
+43
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinghengMeng
requested review from
Mayankm96,
jsmith-bdai and
jtigue-bdai
as code owners
kellyguo11
reviewed
Jun 25, 2025
| @@ -29,6 +29,7 @@ | |||
| entry_point="isaaclab.envs:ManagerBasedRLEnv", | |||
| kwargs={ | |||
| "env_cfg_entry_point": stack_joint_pos_env_cfg.FrankaCubeStackEnvCfg, | |||
| "rsl_rl_cfg_entry_point": f"{agents.__name__}.rsl_rl_ppo_cfg:StackCubePPORunnerCfg", | |||
There was a problem hiding this comment.
I think if we want to add a RL agent cfg for the task, would be good to also extend the task to allow for learning.
There was a problem hiding this comment.
Can you clarify what this task is used for? Do we only want to run it with a random agent?
There was a problem hiding this comment.
current use case for it is only for imitation learning, so it does not have some of the components like rewards needed for reinforcement learning
| @@ -267,6 +267,8 @@ def replace_slices_with_strings(data: dict) -> dict: | |||
| """ | |||
| if isinstance(data, dict): | |||
| return {k: replace_slices_with_strings(v) for k, v in data.items()} | |||
| elif isinstance(data, list): | |||
There was a problem hiding this comment.
might make sense to separate these changes apart from the environment updates so that we can merge these in individually.
6 tasks
kellyguo11
added a commit
that referenced
this pull request
Jul 7, 2025
# Description replace_slices_with_strings() and replace_strings_with_slices() in [IsaacLab/source/isaaclab/isaaclab/utils/dict.py](https://github.com/isaac-sim/IsaacLab/blob/main/source/isaaclab/isaaclab/utils/dict.py) are changed to allow slices being process if a list of dicts is passed in as input. Cherry picks changes from #2571 by @LinghengMeng Fixes #2481 ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This request is to fix the problem of running Isaac-Stack-Cube-Franka-v0 with rsl_rl PPO.
The changes are around the Isaac-Stack-Cube-Franka-v0:
obs_dim = obs.shape[1]To test, run the following:
Note: Because there is no RewardCfg for this task, there will be no learning progress. This can only check the task can be run without any problem.
Fixes #2481
Type of change
Screenshots
obs_dim = obs.shape[1]Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there