Skip to content

Conversation

@t3mi
Copy link
Contributor

@t3mi t3mi commented Sep 22, 2025

What type of PR is this?

  • Enhancement / New Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Test
  • Documentation Update

What this PR does / why we need it:

Adds more customisation options for operator deployment, in particular:

  • allow to set custom labels on a deployment/pod level
  • allow to change revisionHistoryLimit
  • allow to set go runtime env variables or any other env variables
  • allow to set additional arguments for the command
  • allow to set nodeSelector/priorityClassName/topologySpreadConstraints

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR #

Additional information:

@t3mi t3mi requested a review from a team as a code owner September 22, 2025 20:23
@istio-testing
Copy link
Collaborator

Hi @t3mi. Thanks for your PR.

I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fjglira
Copy link
Contributor

fjglira commented Sep 23, 2025

/ok-to-test

@t3mi
Copy link
Contributor Author

t3mi commented Sep 23, 2025

/test gencheck

@istio-testing istio-testing merged commit 516a4d0 into istio-ecosystem:main Oct 6, 2025
13 checks passed
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Oct 6, 2025
* upstream/main:
  fix(helm): add more customisation options (istio-ecosystem#1230)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1254)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1253)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1247)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants