Skip to content

fix(helm): add more customisation options #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2025
+38 −0
Merged

fix(helm): add more customisation options #1230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
861bc06
fix(helm): add more customization options
t3mi Sep 22, 2025
ec85be1
chore: update plain manifests
t3mi Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bundle/manifests/sailoperator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,6 +729,7 @@ spec:
name: sail-operator
spec:
replicas: 1
revisionHistoryLimit: 10
selector:
matchLabels:
app.kubernetes.io/created-by: sailoperator
Expand Down
25 changes: 25 additions & 0 deletions chart/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,14 @@ metadata:
app.kubernetes.io/name: deployment
app.kubernetes.io/part-of: {{ .Values.name }}
control-plane: {{ .Values.deployment.name }}
{{- with .Values.deployment.labels }}
{{- toYaml . | nindent 4 }}
{{- end }}
name: {{ .Values.deployment.name }}
namespace: {{ .Release.Namespace }}
spec:
replicas: 1
revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
selector:
matchLabels:
app.kubernetes.io/created-by: {{ .Values.name }}
Expand All @@ -30,6 +34,9 @@ spec:
app.kubernetes.io/created-by: {{ .Values.name }}
app.kubernetes.io/part-of: {{ .Values.name }}
control-plane: {{ .Values.deployment.name }}
{{- with (.Values.pod).labels }}
{{- toYaml . | nindent 8 }}
{{- end }}
spec:
affinity:
nodeAffinity:
Expand All @@ -47,17 +54,35 @@ spec:
operator: In
values:
- linux
{{- with .Values.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- if .Values.priorityClassName }}
priorityClassName: {{ .Values.priorityClassName }}
{{- end }}
{{- with .Values.tolerations }}
tolerations:
{{- toYaml . | nindent 6 }}
{{- end }}
{{- with .Values.topologySpreadConstraints }}
topologySpreadConstraints:
{{- toYaml . | nindent 6 }}
{{- end }}
containers:
- args:
- --health-probe-bind-address=:8081
- --metrics-bind-address=:8443
- --zap-log-level={{ .Values.operatorLogLevel }}
{{- with .Values.operator.extraArgs }}
{{- tpl (toYaml .) $ | nindent 8 }}
{{- end }}
command:
- /sail-operator
{{- with .Values.operator.env }}
env:
{{- toYaml . | nindent 8 }}
{{- end }}
image: {{ .Values.image }}
{{- if .Values.imagePullPolicy }}
imagePullPolicy: {{ .Values.imagePullPolicy }}
Expand Down
12 changes: 12 additions & 0 deletions chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ deployment:
images.v1_28-alpha_8de61b9a.istiod: gcr.io/istio-testing/pilot:1.28-alpha.8de61b9a1cf9f20f1119f97da6ee939bfd919ffd
images.v1_28-alpha_8de61b9a.proxy: gcr.io/istio-testing/proxyv2:1.28-alpha.8de61b9a1cf9f20f1119f97da6ee939bfd919ffd
images.v1_28-alpha_8de61b9a.cni: gcr.io/istio-testing/install-cni:1.28-alpha.8de61b9a1cf9f20f1119f97da6ee939bfd919ffd
revisionHistoryLimit: 10
service:
port: 8443
serviceAccountName: sail-operator
Expand Down Expand Up @@ -147,6 +148,17 @@ image: quay.io/sail-dev/sail-operator:1.28-latest
# We're commenting out the imagePullPolicy to use k8s defaults
# imagePullPolicy: Always
operator:
# env:
# - name: GOMAXPROCS
# valueFrom:
# resourceFieldRef:
# resource: limits.cpu
# divisor: '1'
# - name: GOMEMLIMIT
# valueFrom:
# resourceFieldRef:
# resource: limits.memory
# divisor: '1'
resources:
limits:
cpu: 500m
Expand Down