General improvements #35

anuchin · 2025-04-07T15:57:36Z

Added the ability to clickthrough the window. The cursor will also not change.
Also removed dialog box which would appear if any error was encountered, for eg trying to solve before taking screenshot.
Added an option to choose auto language which changes the prompt to use the coding language present in screenshot

Also removed dialog box which would appear if any error was enountered. Added an option to choose auto language which changes the prompt to use the coding language present in screenshot

…houpaywall-opensource

bhaumikmaan

The PR is well thought through and includes much needed functionalities. Thanks for your contribution.
@Ornithopter-pilot Please go through it once as well

bhaumikmaan · 2025-04-07T16:08:26Z

electron/ConfigHelper.ts

-        errorMessage = `Error: ${error.message}`;
+        return { valid: false, error: 'OpenAI server error' };
+      } else {
+        return { valid: false, error: error.message || 'Unknown error' };


These are added to bypass the dialog box I believe? Could you explain the diff please?
I think we can make them more meaningful either way!

the app used to open a defauly error dialog box, like in windows, whenever it encountered error....i removed it

That must be because of some error code - I don't think the removal you did is necessary

bhaumikmaan · 2025-04-07T16:09:40Z

electron/ProcessingHelper.ts

@@ -334,14 +307,6 @@ export class ProcessingHelper {
      if (existingExtraScreenshots.length === 0) {
        console.log("Extra screenshot files don't exist on disk");
        mainWindow.webContents.send(this.deps.PROCESSING_EVENTS.NO_SCREENSHOTS);
-
-        dialog.showMessageBox(mainWindow, {


The removal lgtm.
What we could do is to add console logging just to be on the safe side of receiving meaningful feedback

electron/ProcessingHelper.ts

bhaumikmaan · 2025-04-07T16:12:45Z

electron/ProcessingHelper.ts

@@ -661,7 +627,31 @@ export class ProcessingHelper {
      }

      // Create prompt for solution generation
-      const promptText = `
+      const promptText = language === 'auto' ? `


@Ornithopter-pilot Need a deep review on this since it is the heart of the code

@Ornithopter-pilot Need a deep review on this since it is the heart of the code

@bhaumikmaan, thanks for the heads-up! I don't have enough time to do a deep dive today, but I'll definitely check it out later. In the meantime, if you get a chance, feel free to give it a look yourself and share any insights. You know what they say ...two pairs of eyes are better than one! 😄

@Ornithopter-pilot Need a deep review on this since it is the heart of the code

@bhaumikmaan, thanks for the heads-up! I don't have enough time to do a deep dive today, but I'll definitely check it out later. In the meantime, if you get a chance, feel free to give it a look yourself and share any insights. You know what they say ...two pairs of eyes are better than one! 😄

any update? if this pull would be merged or not codebase seems solid to me except the mouse Handeling thing we need to come up with the different approach to make sure mouse tracking doesn't happen when cursor leaves the browser which is happening currently

Not tracking what you are referring to here. Is it a new issue, if so please make an issue for it. If it is for this PR, it still needs changes

this is for settings where llms are instructed to detect which language the solution has to be given based on the screenshot. For eg. one question maybe in Js other SQL. if you set to auto. it will instruct the llm to detect the language and provide soluition in that prgramming language

That makes sense however you shouldn't default to said auto
The reason is because what about the case where a language can't be detected - there should be some reasonable fallback which was python that you changed

https://github.com/Ornithopter-pilot/interview-coder-withoupaywall-opensource/blob/6ee79cad0c5de888bf3d0404d053fca9d5ca0fa2/electron/ProcessingHelper.ts#L191-L195

totargaming · 2025-04-10T04:30:51Z

hope to have this shipped soon, sounds so cool to me :) Though hope the change be tested thoroughly

amiramke · 2025-04-16T05:49:01Z

electron/main.ts

@@ -400,7 +400,7 @@ function showMainWindow(): void {
        ...state.windowSize
      });
    }
-    state.mainWindow.setIgnoreMouseEvents(false);
+    state.mainWindow.setIgnoreMouseEvents(true, { forward: true });


I think this will prevent the user from interacting with the initial config screen (for example, setting the API key). If you already had the API key saved locally before this change, it's easy to overlook

you can interact it for the when you start... you will not be able interact it after you hide once and show it...

I don't think that's a good user experience.

on the other hand i think it is better..when you startm it is ineteractable...but after hiding and showing again it is not which will help you interact with other apps.

I guess this is more complicated than I thought, but Is it possible to have a different behavior for each screen? Interact with the settings screen/button but ignore the mouse for the rest?

vinayshah1998 · 2025-05-30T07:01:56Z

Any updates on getting this merged in?

bhaumikmaan · 2025-05-30T07:04:31Z

Any updates on getting this merged in?

Changes have been requested, as that happens it will go forward

anuchin · 2025-06-08T12:09:19Z

the conflict was just an extra line :)

anuchin · 2025-06-08T12:32:00Z

the project has changed somewhat when i last committed i think...can you specifyt which comment you were referring to?

bhaumikmaan · 2025-06-08T12:33:42Z

Here - See the comments are reply please

bhaumikmaan

Error: electron/ProcessingHelper.ts(615,11): error TS2304: Cannot find name 'problemInfo'.
Error: Process completed with exit code 2.

Build Failed as well. Please refer and fix

anuchin · 2025-06-08T13:08:53Z

regarding the build fail, I will have to look inrto...havent interacted with this project since the last commit...

Regarding

Here is the the comment I was referring to: #35 (comment)

Added another one about renaming problemInfo to responseContent

I thinki explained well enough....You will be able to interact with the program whenever you launch first, you cant ineteract after you hide once, you will have to restart the program to interact with it again...maybe a shortcut would be good, but it defeats the purpose if keyloggers are used...

bhaumikmaan · 2025-06-08T13:12:20Z

Please go over:

@anuchin - Comment

bhaumikmaan · 2025-06-08T13:13:40Z

Error: electron/ProcessingHelper.ts(615,11): error TS2304: Cannot find name 'problemInfo'.
Error: Process completed with exit code 2.
Build Failed as well. Please refer and fix
Reverting the rename of problemInfo to responseContent will resolve the errors. Also, @bhaumikmaan do you have any opinions on how to implement click-through functionality?

From what I understand @anuchin has implemented it by doing:

No click when the tab is hidden (ctrl + h)
Initial config can't be modified after the first change
Anything else I am missing?

You will be able to interact with the program whenever you launch first, you cant ineteract after you hide once, you will have to restart the program to interact with it again

Does this mean that the panel for screen-shots and solution etc can only be seen once and once hidden it can't be brought back?

anuchin · 2025-06-08T13:29:55Z

Does this mean that the panel for screen-shots and solution etc can only be seen once and once hidden it can't be brought back?

no, you can see them every time, but you cant interact with them via mouse...shortcuts will owrk to hide and ungide. Let me be more clear.

When you launch the app everytime, you can interact it with via mouse and keyboard, so you can click on settings etc..then when press the hide button...you can only interact via shortcuts. The app will no longer detect mouse inputs like clicks, cursor will not change when you pass it on the app's screens shot, solutions etc.

You close the app, and lauinch it again, you can interact with mouse and edit the configs etc..The mouse interactive is disabled when you first hide the app after each launch.

bhaumikmaan · 2025-06-08T13:42:35Z

Does this mean that the panel for screen-shots and solution etc can only be seen once and once hidden it can't be brought back?

no, you can see them every time, but you cant interact with them via mouse...shortcuts will owrk to hide and ungide. Let me be more clear.

When you launch the app everytime, you can interact it with via mouse and keyboard, so you can click on settings etc..then when press the hide button...you can only interact via shortcuts. The app will no longer detect mouse inputs like clicks, cursor will not change when you pass it on the app's screens shot, solutions etc.

You close the app, and lauinch it again, you can interact with mouse and edit the configs etc..The mouse interactive is disabled when you first hide the app after each launch.

Great, looks good to me. 2 questions because this somehow hampers the functionalities:

Can the person still scroll when they come into the window?
How will a person copy the code - previously it was by a button on the window, which one can't press now

ZeroKelvinAu added 2 commits April 7, 2025 16:47

Added the ability to click throw indow. The cursor will also not change.

3fbdfbd

Also removed dialog box which would appear if any error was enountered. Added an option to choose auto language which changes the prompt to use the coding language present in screenshot

Merge branch 'main' of https://github.com/greeneu/interview-coder-wit…

4827671

…houpaywall-opensource

bhaumikmaan reviewed Apr 7, 2025

View reviewed changes

bhaumikmaan mentioned this pull request Apr 8, 2025

Replace dialog boxes with in-app notifications for missing screenshots #41

Merged

bhaumikmaan added the enhancement New feature or request label Apr 8, 2025

amiramke reviewed Apr 16, 2025

View reviewed changes

us1415 mentioned this pull request Jun 3, 2025

VISIBLE IN SCREEN SHARING #88

Open

Merge branch 'main' into main

6ee79ca

bhaumikmaan requested changes Jun 8, 2025

View reviewed changes

General improvements #35

Are you sure you want to change the base?

General improvements #35

Uh oh!

Conversation

anuchin commented Apr 7, 2025

Uh oh!

bhaumikmaan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

totargaming commented Apr 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vinayshah1998 commented May 30, 2025

Uh oh!

bhaumikmaan commented May 30, 2025

Uh oh!

anuchin commented Jun 8, 2025

Uh oh!

anuchin commented Jun 8, 2025

Uh oh!

bhaumikmaan commented Jun 8, 2025

Uh oh!

bhaumikmaan left a comment

Choose a reason for hiding this comment

Uh oh!

anuchin commented Jun 8, 2025

Uh oh!

bhaumikmaan commented Jun 8, 2025 • edited by us1415 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bhaumikmaan commented Jun 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anuchin commented Jun 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bhaumikmaan commented Jun 8, 2025

Uh oh!

Uh oh!

bhaumikmaan commented Jun 8, 2025 •

edited by us1415

Loading

bhaumikmaan commented Jun 8, 2025 •

edited

Loading

anuchin commented Jun 8, 2025 •

edited

Loading