General improvements #35
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,10 @@ | ||
| // ProcessingHelper.ts | ||
| import fs from "node:fs" | ||
| import path from "node:path" | ||
|
Check failure on line 3 in electron/ProcessingHelper.ts
|
||
| import { ScreenshotHelper } from "./ScreenshotHelper" | ||
| import { IProcessingHelperDeps } from "./main" | ||
| import * as axios from "axios" | ||
| import { app, BrowserWindow, dialog } from "electron" | ||
|
Check failure on line 7 in electron/ProcessingHelper.ts
|
||
| import { OpenAI } from "openai" | ||
| import { configHelper } from "./ConfigHelper" | ||
| import Anthropic from '@anthropic-ai/sdk'; | ||
|
|
@@ -31,7 +31,7 @@ | |
| finishReason: string; | ||
| }>; | ||
| } | ||
| interface AnthropicMessage { | ||
|
Check failure on line 34 in electron/ProcessingHelper.ts
|
||
| role: 'user' | 'assistant'; | ||
| content: Array<{ | ||
| type: 'text' | 'image'; | ||
|
|
@@ -56,7 +56,7 @@ | |
|
|
||
| constructor(deps: IProcessingHelperDeps) { | ||
| this.deps = deps | ||
| this.screenshotHelper = deps.getScreenshotHelper() | ||
|
|
||
| // Initialize AI client based on config | ||
| this.initializeAIClient(); | ||
|
|
@@ -188,11 +188,11 @@ | |
| } | ||
| } | ||
|
|
||
| // Default to auto instead of python | ||
| return "auto"; | ||
| } catch (error) { | ||
| console.error("Error getting language:", error) | ||
| return "auto" | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -286,7 +286,7 @@ | |
| throw new Error("Failed to load screenshot data"); | ||
| } | ||
|
|
||
| const result = await this.processScreenshotsHelper(validScreenshots, signal) | ||
|
|
||
| if (!result.success) { | ||
| console.log("Processing failed:", result.error) | ||
|
|
@@ -313,7 +313,7 @@ | |
| result.data | ||
| ) | ||
| this.deps.setView("solutions") | ||
| } catch (error: any) { | ||
|
Check failure on line 316 in electron/ProcessingHelper.ts
|
||
| mainWindow.webContents.send( | ||
| this.deps.PROCESSING_EVENTS.INITIAL_SOLUTION_ERROR, | ||
| error | ||
|
|
@@ -346,7 +346,6 @@ | |
| if (!extraScreenshotQueue || extraScreenshotQueue.length === 0) { | ||
| console.log("No extra screenshots found in queue"); | ||
| mainWindow.webContents.send(this.deps.PROCESSING_EVENTS.NO_SCREENSHOTS); | ||
| return; | ||
| } | ||
|
|
||
|
|
@@ -400,11 +399,11 @@ | |
|
|
||
| console.log( | ||
| "Combined screenshots for processing:", | ||
| validScreenshots.map((s) => s.path) | ||
| ) | ||
|
|
||
| const result = await this.processExtraScreenshotsHelper( | ||
| validScreenshots, | ||
| signal | ||
| ) | ||
|
|
||
|
|
@@ -420,7 +419,7 @@ | |
| result.error | ||
| ) | ||
| } | ||
| } catch (error: any) { | ||
|
Check failure on line 422 in electron/ProcessingHelper.ts
|
||
| if (axios.isCancel(error)) { | ||
| mainWindow.webContents.send( | ||
| this.deps.PROCESSING_EVENTS.DEBUG_ERROR, | ||
|
|
@@ -443,48 +442,47 @@ | |
| signal: AbortSignal | ||
| ) { | ||
| try { | ||
| const language = await this.getLanguage(); | ||
| const config = configHelper.loadConfig(); | ||
| const mainWindow = this.deps.getMainWindow(); | ||
|
|
||
| // Create base64 image data array | ||
| const imageDataList = screenshots.map(s => s.data); | ||
|
|
||
| if (mainWindow) { | ||
| mainWindow.webContents.send("processing-status", { | ||
| message: "Analyzing screenshots...", | ||
| progress: 30 | ||
| }); | ||
| } | ||
|
|
||
| let responseContent; | ||
|
|
||
| if (config.apiProvider === "openai") { | ||
| // OpenAI processing | ||
| if (!this.openaiClient) { | ||
| return { | ||
| success: false, | ||
| error: "OpenAI API key not configured. Please check your settings." | ||
| }; | ||
| } | ||
|
|
||
| // Create OpenAI message structure | ||
| const messages = [ | ||
| { | ||
| role: "system" as const, | ||
| content: language === 'auto' ? | ||
| "You are a coding challenge interpreter. Analyze the screenshots of the coding problem, identify the programming language being used, and extract all relevant information. Return the information in JSON format with these fields: problem_statement (which must include the identified programming language), constraints, example_input, example_output. Just return the structured JSON without any other text." : | ||
| "You are a coding challenge interpreter. Analyze the screenshots of the coding problem and extract all relevant information. Return the information in JSON format with these fields: problem_statement, constraints, example_input, example_output. Just return the structured JSON without any other text." | ||
us1415 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, | ||
| { | ||
| role: "user" as const, | ||
| content: [ | ||
| { | ||
| type: "text" as const, | ||
| text: language === 'auto' ? | ||
| "Analyze the screenshots, identify the programming language being used or required, and extract all relevant information. Make sure to include the identified programming language in the problem statement." : | ||
| `Preferred coding language we gonna use for this problem is ${language}.` | ||
| }, | ||
| ...imageDataList.map(data => ({ | ||
| type: "image_url" as const, | ||
|
|
@@ -506,8 +504,8 @@ | |
| try { | ||
| const responseText = extractionResponse.choices[0].message.content; | ||
| // Handle when OpenAI might wrap the JSON in markdown code blocks | ||
| const jsonText = responseText.replace(/```json|```/g, '').trim(); | ||
| responseContent = JSON.parse(jsonText); | ||
| } catch (error) { | ||
| console.error("Error parsing OpenAI response:", error); | ||
| return { | ||
|
|
@@ -531,7 +529,9 @@ | |
| role: "user", | ||
| parts: [ | ||
| { | ||
| text: language === 'auto' ? | ||
| "You are a coding challenge interpreter. Analyze the screenshots of the coding problem, identify the programming language being used, and extract all relevant information. Return the information in JSON format with these fields: problem_statement (which must include the identified programming language), constraints, example_input, example_output. Just return the structured JSON without any other text." : | ||
| `You are a coding challenge interpreter. Analyze the screenshots of the coding problem and extract all relevant information. Return the information in JSON format with these fields: problem_statement, constraints, example_input, example_output. Just return the structured JSON without any other text. Preferred coding language we gonna use for this problem is ${language}.` | ||
| }, | ||
| ...imageDataList.map(data => ({ | ||
| inlineData: { | ||
|
|
@@ -566,7 +566,7 @@ | |
|
|
||
| // Handle when Gemini might wrap the JSON in markdown code blocks | ||
| const jsonText = responseText.replace(/```json|```/g, '').trim(); | ||
| responseContent = JSON.parse(jsonText); | ||
| } catch (error) { | ||
| console.error("Error using Gemini API:", error); | ||
| return { | ||
|
|
@@ -612,7 +612,7 @@ | |
|
|
||
| const responseText = (response.content[0] as { type: 'text', text: string }).text; | ||
| const jsonText = responseText.replace(/```json|```/g, '').trim(); | ||
| problemInfo = JSON.parse(jsonText); | ||
|
Check failure on line 615 in electron/ProcessingHelper.ts
|
||
| } catch (error: any) { | ||
| console.error("Error using Anthropic API:", error); | ||
|
|
||
|
|
@@ -645,13 +645,13 @@ | |
| } | ||
|
|
||
| // Store problem info in AppState | ||
| this.deps.setProblemInfo(responseContent); | ||
|
|
||
| // Send first success event | ||
| if (mainWindow) { | ||
| mainWindow.webContents.send( | ||
| this.deps.PROCESSING_EVENTS.PROBLEM_EXTRACTED, | ||
| responseContent | ||
| ); | ||
|
|
||
| // Generate solutions after successful extraction | ||
|
|
@@ -734,7 +734,31 @@ | |
| } | ||
|
|
||
| // Create prompt for solution generation | ||
| const promptText = language === 'auto' ? ` | ||
|
There was a problem hiding this comment. @Ornithopter-pilot Need a deep review on this since it is the heart of the code There was a problem hiding this comment.
@bhaumikmaan, thanks for the heads-up! I don't have enough time to do a deep dive today, but I'll definitely check it out later. In the meantime, if you get a chance, feel free to give it a look yourself and share any insights. You know what they say ...two pairs of eyes are better than one! 😄 There was a problem hiding this comment.
any update? if this pull would be merged or not codebase seems solid to me except the mouse Handeling thing we need to come up with the different approach to make sure mouse tracking doesn't happen when cursor leaves the browser which is happening currently There was a problem hiding this comment. Not tracking what you are referring to here. Is it a new issue, if so please make an issue for it. If it is for this PR, it still needs changes There was a problem hiding this comment. this is for settings where llms are instructed to detect which language the solution has to be given based on the screenshot. For eg. one question maybe in Js other SQL. if you set to auto. it will instruct the llm to detect the language and provide soluition in that prgramming language There was a problem hiding this comment. That makes sense however you shouldn't default to said |
||
| Generate a detailed solution for the following coding problem. First analyze the problem statement, constraints, and examples to identify the most appropriate programming language, then provide the solution in that language: | ||
|
|
||
| PROBLEM STATEMENT: | ||
| ${problemInfo.problem_statement} | ||
|
|
||
| CONSTRAINTS: | ||
| ${problemInfo.constraints || "No specific constraints provided."} | ||
|
|
||
| EXAMPLE INPUT: | ||
| ${problemInfo.example_input || "No example input provided."} | ||
|
|
||
| EXAMPLE OUTPUT: | ||
| ${problemInfo.example_output || "No example output provided."} | ||
|
|
||
| I need the response in the following format: | ||
| 1. Code: A clean, optimized implementation in the most appropriate programming language (based on the problem and examples) | ||
| 2. Your Thoughts: A list of key insights and reasoning behind your approach | ||
| 3. Time complexity: O(X) with a detailed explanation (at least 2 sentences) | ||
| 4. Space complexity: O(X) with a detailed explanation (at least 2 sentences) | ||
|
|
||
| For complexity explanations, please be thorough. For example: "Time complexity: O(n) because we iterate through the array only once. This is optimal as we need to examine each element at least once to find the solution." or "Space complexity: O(n) because in the worst case, we store all elements in the hashmap. The additional space scales linearly with the input size." | ||
|
|
||
| Your solution should be efficient, well-commented, and handle edge cases. | ||
| ` : ` | ||
| Generate a detailed solution for the following coding problem: | ||
|
|
||
| PROBLEM STATEMENT: | ||
|
|
@@ -889,12 +913,12 @@ | |
| } | ||
|
|
||
| // Extract parts from the response | ||
| const codeMatch = responseContent.match(/```(?:\w+)?\s*([\s\S]*?)```/); | ||
| const code = codeMatch ? codeMatch[1].trim() : responseContent; | ||
|
|
||
| // Extract thoughts, looking for bullet points or numbered lists | ||
| const thoughtsRegex = /(?:Thoughts:|Key Insights:|Reasoning:|Approach:)([\s\S]*?)(?:Time complexity:|$)/i; | ||
| const thoughtsMatch = responseContent.match(thoughtsRegex); | ||
| let thoughts: string[] = []; | ||
|
|
||
| if (thoughtsMatch && thoughtsMatch[1]) { | ||
|
|
@@ -919,7 +943,7 @@ | |
| let timeComplexity = "O(n) - Linear time complexity because we only iterate through the array once. Each element is processed exactly one time, and the hashmap lookups are O(1) operations."; | ||
| let spaceComplexity = "O(n) - Linear space complexity because we store elements in the hashmap. In the worst case, we might need to store all elements before finding the solution pair."; | ||
|
|
||
| const timeMatch = responseContent.match(timeComplexityPattern); | ||
| if (timeMatch && timeMatch[1]) { | ||
| timeComplexity = timeMatch[1].trim(); | ||
| if (!timeComplexity.match(/O\([^)]+\)/i)) { | ||
|
|
@@ -934,7 +958,7 @@ | |
| } | ||
| } | ||
|
|
||
| const spaceMatch = responseContent.match(spaceComplexityPattern); | ||
| if (spaceMatch && spaceMatch[1]) { | ||
| spaceComplexity = spaceMatch[1].trim(); | ||
| if (!spaceComplexity.match(/O\([^)]+\)/i)) { | ||
|
|
@@ -1020,7 +1044,27 @@ | |
| const messages = [ | ||
| { | ||
| role: "system" as const, | ||
| content: language === 'auto' ? | ||
| `You are a coding interview assistant helping debug and improve solutions. Analyze these screenshots which include either error messages, incorrect outputs, or test cases. First identify the programming language from the code, then provide detailed debugging help in that language. | ||
|
|
||
| Your response MUST follow this exact structure with these section headers (use ### for headers): | ||
| ### Issues Identified | ||
| - List each issue as a bullet point with clear explanation | ||
|
|
||
| ### Specific Improvements and Corrections | ||
| - List specific code changes needed as bullet points | ||
|
|
||
| ### Optimizations | ||
| - List any performance optimizations if applicable | ||
|
|
||
| ### Explanation of Changes Needed | ||
| Here provide a clear explanation of why the changes are needed | ||
|
|
||
| ### Key Points | ||
| - Summary bullet points of the most important takeaways | ||
|
|
||
| If you include code examples, use proper markdown code blocks with the appropriate language specification.` : | ||
| `You are a coding interview assistant helping debug and improve solutions. Analyze these screenshots which include either error messages, incorrect outputs, or test cases, and provide detailed debugging help. | ||
|
|
||
| Your response MUST follow this exact structure with these section headers (use ### for headers): | ||
| ### Issues Identified | ||
|
|
@@ -1045,11 +1089,17 @@ | |
| content: [ | ||
| { | ||
| type: "text" as const, | ||
| text: language === 'auto' ? | ||
| `I'm solving this coding problem: "${problemInfo.problem_statement}". Analyze my code to identify the programming language being used, then help me debug or improve my solution. Here are screenshots of my code, the errors or test cases. Please provide a detailed analysis with: | ||
| 1. What issues you found in my code | ||
| 2. Specific improvements and corrections | ||
| 3. Any optimizations that would make the solution better | ||
| 4. A clear explanation of the changes needed` : | ||
| `I'm solving this coding problem: "${problemInfo.problem_statement}" in ${language}. I need help with debugging or improving my solution. Here are screenshots of my code, the errors or test cases. Please provide a detailed analysis with: | ||
| 1. What issues you found in my code | ||
| 2. Specific improvements and corrections | ||
| 3. Any optimizations that would make the solution better | ||
| 4. A clear explanation of the changes needed` | ||
| }, | ||
| ...imageDataList.map(data => ({ | ||
| type: "image_url" as const, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are added to bypass the dialog box I believe? Could you explain the diff please?
I think we can make them more meaningful either way!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the app used to open a defauly error dialog box, like in windows, whenever it encountered error....i removed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That must be because of some error code - I don't think the removal you did is necessary