feat(taosctl): validate pagination args across command groups#1401
Conversation
Add a shared argtypes module (positive_int for --limit, nonneg_int for --offset) and apply it across the merged command groups (catalog, knowledge, memory, search, templates, jobs, benchmarks, mail, scheduler, browsing_history). Non-positive limits and negative offsets now fail at parse time instead of being forwarded to the server as guaranteed-invalid calls. Centralizes the per-command validator CodeRabbit flagged on the dashboard group so the whole pagination surface behaves consistently.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Warning Review limit reached
More reviews will be available in 25 minutes and 14 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (12)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Note Your trial team has used its Gitar budget, so automatic reviews are paused. Upgrade now to unlock full capacity. Comment "Gitar review" to trigger a review manually. Code Review ✅ ApprovedCentralizes pagination argument validation in a shared utility and applies it across ten command groups. This ensures non-positive limits and negative offsets are caught during parsing, with no issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Important Your trial ends in 4 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
Replace the dashboard group's inline _positive_int with the shared tinyagentos/cli/taosctl/argtypes.positive_int (landed in #1401), removing the duplicate now that both are on dev. Behaviour unchanged; --limit still rejects non-positive values at parse time.
Adds a shared
tinyagentos/cli/taosctl/argtypes.py(positive_intfor--limit,nonneg_intfor--offset) and applies it across the merged command groups so non-positive limits and negative offsets fail at parse time instead of being forwarded to the server as guaranteed-invalid calls.Generalizes the per-command validator CodeRabbit flagged on the dashboard group (#1399) into one shared helper, applied consistently across the pagination surface.
Touched groups
catalog, knowledge, memory, search, templates, jobs, benchmarks, mail, scheduler, browsing_history. Each
--limit->positive_int, each--offset->nonneg_int. Ports, seeds, durations, and intervals are left alone (different semantics).Tests
New
tests/test_taosctl_argtypes.pyunit-tests both validators and confirms a representative group (memory list) rejects--limit 0/--offset -1without dispatching, while valid paging still dispatches. Full taosctl suite: 264 passed (incl. route-coverage gate).Follow-up
The dashboard group (#1399, gating) carries an inline
_positive_int; once it merges it can be deduped to import the shared helper.