-
-
Notifications
You must be signed in to change notification settings - Fork 300
Include get_child_inlines() hook in stacked inline admin forms. #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #681 +/- ##
==========================================
+ Coverage 75.53% 75.57% +0.03%
==========================================
Files 21 21
Lines 1345 1347 +2
Branches 213 213
==========================================
+ Hits 1016 1018 +2
Misses 257 257
Partials 72 72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ccefee6 to
cd2a0c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The class hierarchy walks as default fool proof default behavior are the main reason of my previous PR #582 that you've closed, since this one would surpass It. If you are not willing to have that default behavior and instead raise an exception if child_classes is not defined (that IMHO would make this class useless being used alone without inheriting It in another child one), then please reopen again my PR. |
f1a59fa to
7ca3a8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
13a15ad to
67b6655
Compare
Co-authored-by: Jesús Leganés-Combarro 'piranna <[email protected]> Co-authored-by: Brian Kohan <[email protected]>
67b6655 to
79cd97c
Compare
Replaces #582
Fixes #576