Skip to content

Conversation

@bckohan
Copy link
Contributor

@bckohan bckohan commented Dec 8, 2025

Replaces #582

Fixes #576

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.57%. Comparing base (94267f3) to head (79cd97c).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
+ Coverage   75.53%   75.57%   +0.03%     
==========================================
  Files          21       21              
  Lines        1345     1347       +2     
  Branches      213      213              
==========================================
+ Hits         1016     1018       +2     
  Misses        257      257              
  Partials       72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bckohan bckohan changed the title Auto discover subclasses in polymorphic model admin. Include get_child_inlines() hook in stacked inline admin forms. Dec 8, 2025
@bckohan bckohan force-pushed the TRC-Informatica/master branch 2 times, most recently from ccefee6 to cd2a0c3 Compare December 8, 2025 04:53
@bckohan bckohan requested a review from Copilot December 8, 2025 04:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@piranna
Copy link
Contributor

piranna commented Dec 8, 2025

The class hierarchy walks as default fool proof default behavior are the main reason of my previous PR #582 that you've closed, since this one would surpass It. If you are not willing to have that default behavior and instead raise an exception if child_classes is not defined (that IMHO would make this class useless being used alone without inheriting It in another child one), then please reopen again my PR.

@bckohan bckohan force-pushed the TRC-Informatica/master branch 2 times, most recently from f1a59fa to 7ca3a8d Compare December 8, 2025 05:11
@bckohan bckohan requested a review from Copilot December 8, 2025 05:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bckohan bckohan force-pushed the TRC-Informatica/master branch from 13a15ad to 67b6655 Compare December 8, 2025 06:38
Co-authored-by: Jesús Leganés-Combarro 'piranna <[email protected]>
Co-authored-by: Brian Kohan <[email protected]>
@bckohan bckohan force-pushed the TRC-Informatica/master branch from 67b6655 to 79cd97c Compare December 8, 2025 06:54
@bckohan bckohan merged commit 6e2c702 into master Dec 8, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add PolymorphicInlineModelAdmin.get_child_inlines()

2 participants