Skip to content

add log in plugin autoloader #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from
Open

add log in plugin autoloader #3020

wants to merge 1 commit into from

Conversation

pifou25
Copy link
Contributor

@pifou25 pifou25 commented Jan 27, 2025 •
edited
Loading

Description

add log in case of plugin error via the plugin autoloader, this is a great help for plugin developers :)

Suggested changelog entry

add log in case of plugin error via the plugin autoloader

Related issues/external references

Fixes #3017

Types of changes

  • Bug fix (non-breaking change which fixes)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

@Mips2648
Copy link
Collaborator

Why do you log exception in "core"? this is weird... who will ever thought about checking this log?

@pifou25
Copy link
Contributor Author

pifou25 commented Jan 30, 2025

Not sure where to put this log, and 'core' is the default for log path

core/core/class/log.class.php

Line 180 in 61c6ce2

public static function getPathToLog($_log = 'core') {

what else do you suggest ? 'plugin' could be better ?

kwizer15
kwizer15 reviewed Apr 27, 2025
View reviewed changes
core/php/core.inc.php
if ($plugin_active == 1) {
try {
include_file('core', $classname, 'class', $classname);
} catch (Exception $e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comme on ne gère plus sous php7.4, je propose de remplacer ces double catch par des catch (Throwable $e).
Pas nécessaire de le faire partout, mais si ca peut se faire au fur et à mesure qu'on passe sur du code ca sera déjà pas mal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui aucun intérêt de faire 2 catch si le traitement est identique.
(le rapport avec php7.4 ? c'est déjà possible je pense dès php7 d'après la doc)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'était juste pour préciser que c'était pleinement géré sur cette version, rien de plus.

@pifou25 pifou25 force-pushed the feat/log_errors branch from 9a648d7 to 40a16cb Compare May 24, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoic21 zoic21 zoic21 approved these changes

@Hotfirenet Hotfirenet Hotfirenet approved these changes

@Mips2648 Mips2648 Awaiting requested review from Mips2648

@Salvialf Salvialf Awaiting requested review from Salvialf

@Sekiro-kost Sekiro-kost Awaiting requested review from Sekiro-kost

+1 more reviewer

@kwizer15 kwizer15 kwizer15 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] PHP Parse error dans *pluginid*/plugin_info/install.php n'est pas envoyé vers http.error
9 participants
@pifou25 @Mips2648 @kwizer15 @zoic21 @Hotfirenet @tmartinez69009 @Salvialf @Sekiro-kost @reineabs