Skip to content

add log in plugin autoloader #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from
Open

add log in plugin autoloader #3020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/php/core.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ function jeedomAutoload($_classname) {
try {
include_file('core', $classname, 'class', $classname);
} catch (Exception $e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comme on ne gère plus sous php7.4, je propose de remplacer ces double catch par des catch (Throwable $e).
Pas nécessaire de le faire partout, mais si ca peut se faire au fur et à mesure qu'on passe sur du code ca sera déjà pas mal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui aucun intérêt de faire 2 catch si le traitement est identique.
(le rapport avec php7.4 ? c'est déjà possible je pense dès php7 d'après la doc)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'était juste pour préciser que c'était pleinement géré sur cette version, rien de plus.


log::add( 'plugin', 'error', $e->getMessage());
} catch (Error $e) {

log::add( 'plugin', 'error', $e->getMessage());
}
}
}
Expand Down