-
Notifications
You must be signed in to change notification settings - Fork 263
Fix Usb Gadget when attached after power-up #1062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 42 out of 42 changed files in this pull request and generated 17 comments.
Comments suppressed due to low confidence (2)
internal/usbgadget/usbgadget.go:185
- File handle may be writable as a result of data flow from a call to OpenFile and closing it may result in data loss upon failure, which is not handled explicitly.
u.absMouseHidFile.Close()
internal/usbgadget/usbgadget.go:189
- File handle may be writable as a result of data flow from a call to OpenFile and closing it may result in data loss upon failure, which is not handled explicitly.
u.relMouseHidFile.Close()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
15e3ece to
6bdbca4
Compare
6bdbca4 to
96d7189
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LED state synchronization stops working after 1-2 runs of make test_e2e. The keyboard and mouse movement both work, it's just the LED state that stops updating. A restart fixes the issue.
Also, worth mentioning is that I can also reproduce this issue latest dev without this PR.
|
I will look into the LED state issue. When you say it "stops working" do you mean that the client doesn't track the server state, or do you mean the UI doesn't track the RPC pushes? |
|
The remote host receives all keys and mouse events, it's just that the UI doesn't properly reflect the LED State. This makes the |
I'll dig in this weekend... what LED state are we tracking, and what is the test JetKVM physically attached to on the USB port? I notice that MacOS doesn't light the CapsLock LED as I would expect (never really has...) Do you know what kind of machine the Jet is driving? |
Fixes #128
Summary