Add test for #1197 #1269
Merged
Add test for #1197 #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoid multiple calls to toLowerCase * Make local variables finals
benmccann
reviewed
Jan 3, 2025
| @@ -129,15 +129,16 @@ public String[] getColumnNames( | |||
| * @param headerNames The header names to be potentially adjusted. | |||
| */ | |||
| private void renameDuplicateColumnHeaders(String[] headerNames) { | |||
| Map<String, Integer> nameCounter = new HashMap<>(); | |||
| final Map<String, Integer> nameCounter = new HashMap<>(); | |||
There was a problem hiding this comment.
Let's remove final everywhere. It doesn't match the style of the codebase
Maybe we can consider whether to migrate to var after a release has been out for awhile if folks don't complain about us dropping Java 8. Perhaps final var would look less noisy than final looks with types. The other option might be lombok's val, but not sure if I'd want to introduce something that non-standard
benmccann
reviewed
Jan 3, 2025
| void allowDuplicateColumnNamesInsensitive() throws IOException { | ||
| final Reader reader2 = | ||
| new StringReader( | ||
| "Col1" + COMMA + "col1" + LINE_END + "\"first\"" + COMMA + "second" + LINE_END); |
There was a problem hiding this comment.
We could probably make this a tad simpler
Suggested change
| "Col1" + COMMA + "col1" + LINE_END + "\"first\"" + COMMA + "second" + LINE_END); | |
| "Col1" + COMMA + "col1" + LINE_END + "first" + COMMA + "second" + LINE_END); |
There was a problem hiding this comment.
Sure, I took that from the test above. Done
benmccann
reviewed
Jan 3, 2025
Co-authored-by: Ben McCann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing.
Description
Testing
Yes