Merged
Conversation
26 tasks
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 93.42% 94.70% +1.28%
==========================================
Files 3 3
Lines 289 359 +70
==========================================
+ Hits 270 340 +70
Misses 19 19
Continue to review full report at Codecov.
|
Member
Author
|
Merging this for now, since MOI support might be a while away. If we decide to add Reified to MOI, we can remove from MiniZinc.jl and release a breaking v0.2 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of jump-dev/MathOptInterface.jl#1805 (comment).
Adding to MiniZinc.jl first to work out the kinks before we decide to add to MOI. I think that adding the Reified set with minimal infrastructure might be the way to go. It's a pretty solid/standard set and we already have
Indicator, but it'd need a lot of other stuff before it was useful to non-constraint programming solvers.MiniZinc doesn't support reified constraints for complicated sets like Table, Path, Cumulative, etc. It's been trial and error to see which are supported and which aren't.
CircuitMiniZinc: evaluation error: Abort: Reified circuit/1 is not supported.PathMiniZinc: evaluation error: Abort: Reified path constraint is not supported