Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow querying is_set_by_optimize attributes unless explicitly supported #88

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

odow
Copy link
Member

@odow odow commented Oct 22, 2024

If we forward to the solver, it will just be whatever the last solve was, which is probably not meaningful.

Closes #86

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (084ca30) to head (f61cb81).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   96.45%   96.46%   +0.01%     
==========================================
  Files           9        9              
  Lines         959      962       +3     
==========================================
+ Hits          925      928       +3     
  Misses         34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit f5d7b81 into master Oct 22, 2024
7 checks passed
@odow odow deleted the od/unsupported branch October 22, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Some attributes don't make sense to query
1 participant