Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow querying is_set_by_optimize attributes unless explicitly supported #88

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Disallow querying is_set_by_optimize attributes unless explicitly supported #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7cbccd
Disallow querying is_set_by_optimize attributes unless explicitly sup…
odow Oct 22, 2024
d2e0550
Update
odow Oct 22, 2024
2120d66
Update
odow Oct 22, 2024
f61cb81
Fix
odow Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/MultiObjectiveAlgorithms.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,10 +446,18 @@ function MOI.set(model::Optimizer, attr::_ATTRIBUTES, args...)
end

function MOI.get(model::Optimizer, attr::_ATTRIBUTES, args...)
if MOI.is_set_by_optimize(attr)
msg = "MOA does not support querying this attribute."
throw(MOI.GetAttributeNotAllowed(attr, msg))
end
return MOI.get(model.inner, attr, args...)
end

function MOI.get(model::Optimizer, attr::_ATTRIBUTES, arg::Vector{T}) where {T}
if MOI.is_set_by_optimize(attr)
msg = "MOA does not support querying this attribute."
throw(MOI.GetAttributeNotAllowed(attr, msg))
end
return MOI.get.(model, attr, arg)
end

Expand Down Expand Up @@ -569,6 +577,14 @@ function MOI.get(
return sol.x[x]
end

function MOI.get(
model::Optimizer,
attr::MOI.VariablePrimal,
x::Vector{MOI.VariableIndex},
)
return MOI.get.(model, attr, x)
end

function MOI.get(model::Optimizer, attr::MOI.ObjectiveValue)
return model.solutions[attr.result_index].y
end
Expand Down
24 changes: 24 additions & 0 deletions test/test_model.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,30 @@ function test_solve_time()
return
end

function test_unnsupported_attributes()
model = MOA.Optimizer(HiGHS.Optimizer)
MOI.set(model, MOI.Silent(), true)
x = MOI.add_variables(model, 2)
c = MOI.add_constraint.(model, x, MOI.GreaterThan(0.0))
f = MOI.Utilities.operate(vcat, Float64, 1.0 .* x...)
MOI.set(model, MOI.ObjectiveFunction{typeof(f)}(), f)
MOI.set(model, MOI.ObjectiveSense(), MOI.MAX_SENSE)
MOI.optimize!(model)
@test_throws(
MOI.GetAttributeNotAllowed{MOI.RelativeGap},
MOI.get(model, MOI.RelativeGap()),
)
@test_throws(
MOI.GetAttributeNotAllowed{MOI.DualObjectiveValue},
MOI.get(model, MOI.DualObjectiveValue()),
)
@test_throws(
MOI.GetAttributeNotAllowed{MOI.ConstraintDual},
MOI.get(model, MOI.ConstraintDual(), c),
)
return
end

end

TestModel.run_tests()
Loading