Fixing Buttons Overlapping bug #26
Conversation
style/base.css
Outdated
| gap: 2px; | ||
| padding: 0; | ||
| line-height: 1; | ||
| margin-top: 20px; |
There was a problem hiding this comment.
Curious, that would mean it applies to all chunks?
Do you have screenshot of what it looks like with a bigger diff?
There was a problem hiding this comment.
Wondering otherwise if we should only treat the case of the first chunk separately, so it does not overlap with the cell toolbar.
There was a problem hiding this comment.
@jtpio I have shared some screenshots.
|
Want screenshots like this 
|
|
Thanks. Curious how this will work when we allow inline diffs? #27 Will the buttons be "off" due to the extra margin? |
|
Its hard to say without experiencing but i also think the buttons be "off" due to the extra margin? |
|
Hey y'all, I don't think we should be adding this spacing to every diff, just to solve the first line problem when cell buttons overlap. From an aesthetic perspective, it doesn't look right to me that these buttons aren't always flush in the very top right of the diff. I believe a better approach—though I recognize this might be difficult to achieve—would be to disable/hide the cell tools when a diff is visible. When showing a diff, I don't think the user needs the cell tools until they are done handling the diff, so it's appropriate to hide them. |
Sounds Good! |
|
@nakul-py yeah, this looks great! Thank you for implementing this. One more question... after accepting/rejecting the diff, does the cell toolbar come back? I want to make sure we don't permanently hide the toolbar. It should reappear as soon as the diff is handled. |
|
Yes cell toolbar comes back when diff is completed as you can also see in Screencast.From.2025-10-25.13-35-36.mp4 |
|
LGTM! Thanks @nakul-py! |
3 participants
This Pr fixes Accept and Reject changes buttons overlapping with cell toolbar bug.
Now when the diff is active cell toolbar hides and visible when diff is deactivated.
Thanks @Zsailer for this better and clean apporoach.
Screencast.From.2025-10-25.13-35-36.mp4
CC @jtpio @Zsailer @brichet