Skip to content

Fixing Buttons Overlapping bug #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2025
Merged

Fixing Buttons Overlapping bug #26

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d6435b
Fixing Buttons Overlapping bug
nakul-py Oct 23, 2025
1e470d5
Hide Cell toolbar if diff is active
nakul-py Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions style/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
gap: 2px;
padding: 0;
line-height: 1;
margin-top: 20px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, that would mean it applies to all chunks?

Do you have screenshot of what it looks like with a bigger diff?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering otherwise if we should only treat the case of the first chunk separately, so it does not overlap with the cell toolbar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtpio I have shared some screenshots.

}

/* Style our custom JupyterLab icon buttons to match CodeMirror line height */
Expand Down
Loading