fix: respect forceRefresh in balance fetch deduplication#36
Merged
BitHighlander merged 2 commits intodevelopfrom Apr 5, 2026
Merged
fix: respect forceRefresh in balance fetch deduplication#36BitHighlander merged 2 commits intodevelopfrom
BitHighlander merged 2 commits intodevelopfrom
Conversation
Previously, fetchBalancesFromPioneer(forceRefresh=true) would return the existing in-progress promise, ignoring the force flag. Now the dedup check is skipped when forceRefresh is requested. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When a forceRefresh call bypasses dedup while a prior fetch is still in-flight, both promises run concurrently. The older promise's finally would null out balancesFetchInProgress even after the newer force-refresh promise had replaced it, causing subsequent callers to miss the in-flight force fetch and spawn redundant RPC calls. Fix by only clearing the ref when it still points to this promise. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
BitHighlander
added a commit
that referenced
this pull request
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchBalancesFromPioneer(forceRefresh=true)no longer returns stale in-progress promiseTest plan
🤖 Generated with Claude Code