Skip to content

[RNKC-054] - detect keyboard size changes (post post fix) #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Aug 30, 2022

Description

It turned out on API 30 onApplyWindowInsets can also be dispatched during keyboard animation.

Motivation and Context

To fix it I added a check !isTransitioning. It will exclude false positive calls and animation will be smooth.

Related PRs/issues:

Changelog

Android

  • added isTransitioning property (changes its values in onStart/onEnd);
  • use isTransitioning variable to prevent undesired calls.

How Has This Been Tested?

Tested on:

  • API 25
  • API 28
  • API 29
  • API 30
  • API 31
  • API 32

Checklist

  • CI successfully passed

@kirillzyusko kirillzyusko added the 🐛 bug Something isn't working label Aug 30, 2022
@kirillzyusko kirillzyusko merged commit 52f8d2d into main Aug 31, 2022
@kirillzyusko kirillzyusko deleted the bugfix/keyboard-size-changes-api-30 branch August 31, 2022 07:58
@kirillzyusko kirillzyusko added the 🤖 android Android specific label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Android specific 🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant