Skip to content

Conversation

@kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Aug 30, 2022

Description

It turned out on API 30 onApplyWindowInsets can also be dispatched during keyboard animation.

Motivation and Context

To fix it I added a check !isTransitioning. It will exclude false positive calls and animation will be smooth.

Related PRs/issues:

Changelog

Android

  • added isTransitioning property (changes its values in onStart/onEnd);
  • use isTransitioning variable to prevent undesired calls.

How Has This Been Tested?

Tested on:

  • API 25
  • API 28
  • API 29
  • API 30
  • API 31
  • API 32

Checklist

  • CI successfully passed

@kirillzyusko kirillzyusko added the 🐛 bug Something isn't working label Aug 30, 2022
@kirillzyusko kirillzyusko merged commit 52f8d2d into main Aug 31, 2022
@kirillzyusko kirillzyusko deleted the bugfix/keyboard-size-changes-api-30 branch August 31, 2022 07:58
@kirillzyusko kirillzyusko added the 🤖 android Android specific label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖 android Android specific 🐛 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants