Skip to content

[RNKC-054] - detect keyboard size changes (post post fix) #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2022
Merged

[RNKC-054] - detect keyboard size changes (post post fix) #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion android/src/main/java/com/reactnativekeyboardcontroller/KeyboardAnimationCallback.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ class KeyboardAnimationCallback(
private val TAG = KeyboardAnimationCallback::class.qualifiedName
private var persistentKeyboardHeight = 0
private var isKeyboardVisible = false
private var isTransitioning = false

init {
require(persistentInsetTypes and deferredInsetTypes == 0) {
Expand All @@ -64,10 +65,11 @@ class KeyboardAnimationCallback(
override fun onApplyWindowInsets(v: View, insets: WindowInsetsCompat): WindowInsetsCompat {
// when keyboard appears values will be (false && true)
// when keyboard disappears values will be (true && false)
// `!isTransitioning` check is needed to avoid calls of `onApplyWindowInsets` during keyboard animation
// having such check allows us not to dispatch unnecessary incorrect events
// the condition will be executed only when keyboard is opened and changes its size
// (for example it happens when user changes keyboard type from 'text' to 'emoji' input
if (isKeyboardVisible && isKeyboardVisible() && Build.VERSION.SDK_INT >= 30) {
if (isKeyboardVisible && isKeyboardVisible() && !isTransitioning && Build.VERSION.SDK_INT >= 30) {
val keyboardHeight = getCurrentKeyboardHeight()

this.emitEvent("KeyboardController::keyboardWillShow", getEventParams(keyboardHeight))
Expand All @@ -93,6 +95,7 @@ class KeyboardAnimationCallback(
animation: WindowInsetsAnimationCompat,
bounds: WindowInsetsAnimationCompat.BoundsCompat
): WindowInsetsAnimationCompat.BoundsCompat {
isTransitioning = true
isKeyboardVisible = isKeyboardVisible()
val keyboardHeight = getCurrentKeyboardHeight()

Expand Down Expand Up @@ -143,6 +146,7 @@ class KeyboardAnimationCallback(
override fun onEnd(animation: WindowInsetsAnimationCompat) {
super.onEnd(animation)

isTransitioning = false
this.persistentKeyboardHeight = getCurrentKeyboardHeight()
this.emitEvent("KeyboardController::" + if (!isKeyboardVisible) "keyboardDidHide" else "keyboardDidShow", getEventParams(this.persistentKeyboardHeight))
}
Expand Down