-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: eslint jest rules #2349
chore: eslint jest rules #2349
Conversation
Size Change: -4 B (0%) Total Size: 427 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with most of these rules, but I would like to discuss jest/consistent-test-it
. I like the freedom of sometimes using it
and sometimes test
because it
tests can be read like "it uses media queries", where test
tests can be read like "test accessibility" and "test styles". I don't think enforcing either one brings value, I like combining them.
@silvenon i think it's better to have consistency and left only |
860e859
to
a70b7bf
Compare
a70b7bf
to
9e09cb4
Compare
I don't have any strong opinion for |
they are the same, just naming differences |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'm fine with either 👍 please resolve conflicts.
9e09cb4
to
b15843a
Compare
b15843a
to
1110c8e
Compare
it
consistent-test-itFixes #2348.
and etc.
LiveURL: https://orbit-chore-eslint-jest-only.surge.sh