chore: eslint jest rules

config/eslintJS.js

@@ -62,5 +62,10 @@ module.exports = {
     "no-await-in-loop": "off",
     "react-hooks/rules-of-hooks": "error",
     "react-hooks/exhaustive-deps": "warn",
+    "jest/no-identical-title": "error",
+    "jest/no-standalone-expect": "error",
+    "jest/no-if": "error",
+    "jest/consistent-test-it": "warn",
+    "jest/no-focused-tests": "error",
   },
 };

packages/orbit-components/src/Breadcrumbs/__tests__/index.test.js

@@ -13,7 +13,7 @@ import BreadcrumbsItem from "../BreadcrumbsItem";
 // inaccessible, so we're replacing <Hide> with a dummy component
 jest.mock("../../Hide", () => ({ children }) => children);
 
-describe("Breadcrumbs", () => {
+describe("#Breadcrumbs", () => {
   const dataTest = "test";
   const onGoBack = jest.fn();
   beforeEach(() => {
@@ -31,12 +31,14 @@ describe("Breadcrumbs", () => {
     expect(screen.getByLabelText("Breadcrumb")).toBeInTheDocument();
     expect(screen.getByTestId(dataTest)).toBeInTheDocument();
   });
+
   it("ol should contain correct item type", () => {
     expect(screen.getByRole("list")).toHaveAttribute(
       "itemType",
       expect.stringContaining("BreadcrumbList"),
     );
   });
+
   it("children should contain active and contentKey", () => {
     expect(screen.getByRole("listitem")).toHaveAttribute("aria-current", "page");
     expect(document.querySelector("meta")).toHaveAttribute("content", "1");

packages/orbit-components/src/CallOutBanner/__tests__/index.test.js

@@ -48,6 +48,9 @@ describe("CallOutBanner - actionable", () => {
   it("should have tabIndex", () => {
     expect(banner.render().prop("tabindex")).toBe("0");
   });
-  banner.simulate("click");
-  expect(onClick).toHaveBeenCalled();
+
+  it("should be clickabel", () => {
+    banner.simulate("click");
+    expect(onClick).toHaveBeenCalled();
+  });
 });

packages/orbit-components/src/Heading/__tests__/index.test.js

@@ -50,8 +50,6 @@ describe("Heading in DIV, type Title5", () => {
   );
   it("should have text-transform uppercase", () => {
     expect(component.render().prop("name")).toBe(as);
-  });
-  it("should have text-transform uppercase", () => {
     expect(component).toHaveStyleRule("text-transform", "uppercase");
   });
 });

packages/orbit-components/src/InputGroup/__tests__/index.test.js

@@ -69,13 +69,11 @@ describe(`InputGroup - Phone number`, () => {
   });
   it("should contain a select", () => {
     expect(select.exists()).toBe(true);
+    expect(component.render().prop("data-test")).toBe(dataTest);
   });
   it("should have spaceAFter", () => {
     expect(group.prop("spaceAfter")).toBe(spaceAfter);
   });
-  it("should contain a select", () => {
-    expect(component.render().prop("data-test")).toBe(dataTest);
-  });
   it("should contain a fake div with styling", () => {
     expect(component.find("InputGroup__FakeGroup").exists()).toBe(true);
   });

packages/orbit-components/src/Layout/consts.js

@@ -20,17 +20,17 @@ export const LAYOUT_SETTINGS = {
       columns: "256px 1fr 288px",
     },
     layoutColumns: {
-      // prettier-ignore
-      "0": {
+      // $FlowIssue
+      0: {
         hideOn: ["smallMobile", "mediumMobile", "largeMobile"],
         element: "aside",
       },
-      // prettier-ignore
-      "1": {
+      // $FlowIssue
+      1: {
         element: "main",
       },
-      // prettier-ignore
-      "2": {
+      // $FlowIssue
+      2: {
         hideOn: ["smallMobile", "mediumMobile", "largeMobile", "tablet", "desktop"],
       },
     },
@@ -46,12 +46,12 @@ export const LAYOUT_SETTINGS = {
       columnGap: "24px",
     },
     layoutColumns: {
-      // prettier-ignore
-      "0": {
+      // $FlowIssue
+      0: {
         element: "main",
       },
-      // prettier-ignore
-      "1": {
+      // $FlowIssue
+      1: {
         element: "aside",
       },
     },
@@ -64,8 +64,8 @@ export const LAYOUT_SETTINGS = {
       columnGap: "24px",
     },
     layoutColumns: {
-      // prettier-ignore
-      "0": {
+      // $FlowIssue
+      0: {
         element: "main",
       },
     },

packages/orbit-components/src/Select/__tests__/Select.test.js

@@ -47,8 +47,6 @@ describe("Select", () => {
   });
   it("should have data-state", () => {
     expect(select.render().prop("data-state")).toBe("ok");
-  });
-  it("should have data-state", () => {
     expect(select.render().prop("data-recording-ignore")).toBe("true");
   });
   it("should have name", () => {
@@ -62,8 +60,6 @@ describe("Select", () => {
   });
   it("should have placeholder", () => {
     expect(select.childAt(0).text()).toBe(placeholder);
-  });
-  it("should have placeholder", () => {
     expect(select.render().prop("id")).toBe(id);
   });
 });