Skip to content

feat: add possibility to disable pushing of image in deploy command #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2022
Merged

feat: add possibility to disable pushing of image in deploy command #736

merged 1 commit into from
Jan 6, 2022

Conversation

zroubalik
Copy link
Contributor

@zroubalik zroubalik commented Jan 6, 2022 •
edited
Loading

Signed-off-by: Zbynek Roubalik [email protected]

This is needed to have standalone deploy Tekton task.

Basically implementing the same functionality that has been done in #681 for build.

Changes

  • 🎁 add possibility to disable pushing of image in deploy command

/kind enhancement

Relates: #620

@knative-prow-robot knative-prow-robot added kind/enhancement approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 6, 2022
@codecov
Copy link

codecov bot commented Jan 6, 2022 •
edited
Loading

Codecov Report

Merging #736 (1b5ccf2) into main (3177287) will increase coverage by 0.00%.
The diff coverage is 28.57%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #736   +/-   ##
=======================================
  Coverage   41.56%   41.56%           
=======================================
  Files          42       42           
  Lines        4083     4102   +19     
=======================================
+ Hits         1697     1705    +8     
- Misses       2135     2144    +9     
- Partials      251      253    +2
Impacted Files Coverage Δ
cmd/deploy.go 16.03% <5.00%> (-0.14%) ⬇️
client.go 65.02% <57.14%> (-0.07%) ⬇️
cmd/build.go 58.08% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3177287...1b5ccf2. Read the comment docs.

salaboy
salaboy approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@salaboy salaboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2022
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: salaboy, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 4e5a5e8 into knative:main Jan 6, 2022
@zroubalik
Copy link
Contributor Author

ouch, @salaboy e2e tests were failing and I was working on a fix. It hasn't been ready for a merge.

zroubalik added a commit that referenced this pull request Jan 6, 2022
@zroubalik
Revert "feat: add possibility to disable pushing of image in deploy…
c82ce46 
… command (#736)"

This reverts commit 4e5a5e8.
@zroubalik zroubalik mentioned this pull request Jan 6, 2022
Merged
knative-prow-robot pushed a commit that referenced this pull request Jan 6, 2022
@zroubalik
Revert "feat: add possibility to disable pushing of image in deploy…
2282cf8 
… command (#736)" (#738)

This reverts commit 4e5a5e8.
jrangelramos added a commit to jrangelramos/func that referenced this pull request Feb 22, 2024
@jrangelramos @matejvasek
Update Quarkus Patch to 3.7.1 (knative#736)
ff93a25 
* chore: update quarkus patch file with 3.7.1 quarkus version

* Update 0002-quarkus-productized.patch

---------

Co-authored-by: Matej Vasek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salaboy salaboy salaboy approved these changes

@lance lance Awaiting requested review from lance

@lkingland lkingland Awaiting requested review from lkingland

@matejvasek matejvasek Awaiting requested review from matejvasek

Assignees

@salaboy salaboy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zroubalik @knative-prow-robot @salaboy