Skip to content

Remove obsolete Spotlight and 1Password tables - #2791

Open
cesarfda wants to merge 1 commit into
kolide:mainfrom
cesarfda:remove-spotlight-onepassword-tables
Open

Remove obsolete Spotlight and 1Password tables#2791
cesarfda wants to merge 1 commit into
kolide:mainfrom
cesarfda:remove-spotlight-onepassword-tables

Conversation

@cesarfda

Copy link
Copy Markdown
Contributor

Summary

  • remove kolide_spotlight, which is redundant with osquery's mdfind table
  • remove kolide_onepassword_accounts, which reads legacy 1Password SQLite formats and is no longer used
  • stop registering and publishing both tables in the launcher schema

Test plan

  • Run go test ./pkg/osquery/table -count=1
  • Run make lint

Dependency

Stop registering legacy capabilities that no longer produce useful customer results and remove them from the published schema.

@brhoades brhoades left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems simple enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants